Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rpc][state.list_resource] add resource type filter #3586

Merged
merged 6 commits into from
Jul 30, 2022

Conversation

jiangying000
Copy link
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: 3447

What is the new behavior?

curl 'http://localhost:9850' -H 'content-type: application/json' --data-raw '{"method":"state.list_resource","params":["0x8355417c88d969f656935244641256ad",{"decode": true, "max_size": 30000, "start_index": 0, "resource_types": ["0x00000000000000000000000000000001::Account::Balance", "0x00000000000000000000000000000001::NFTGallery::NFTGallery"] }],"id":53,"jsonrpc":"2.0"}'

  • add resource_types filter
    {"decode": true, "max_size": 30000, "start_index": 0, "resource_types": ["0x00000000000000000000000000000001::Account::Balance", "0x00000000000000000000000000000001::NFTGallery::NFTGallery"] }

Other information

@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #3586 (9405d85) into master (18a055f) will decrease coverage by 0.06%.
The diff coverage is 5.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3586      +/-   ##
==========================================
- Coverage   29.09%   29.04%   -0.05%     
==========================================
  Files         589      589              
  Lines       49797    49814      +17     
  Branches    23432    23441       +9     
==========================================
- Hits        14483    14462      -21     
- Misses      21100    21185      +85     
+ Partials    14214    14167      -47     
Flag Coverage Δ
unittests 29.04% <5.89%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/starcoin/src/account/nft_cmd.rs 0.00% <0.00%> (ø)
cmd/starcoin/src/account/show_cmd.rs 0.00% <0.00%> (ø)
cmd/starcoin/src/state/list_cmd.rs 0.00% <0.00%> (ø)
rpc/client/src/lib.rs 11.22% <0.00%> (-0.02%) ⬇️
rpc/server/src/module/state_rpc.rs 4.91% <0.00%> (-0.25%) ⬇️
state/statedb/src/tests.rs 23.47% <ø> (ø)
rpc/api/src/state/mod.rs 32.61% <50.00%> (+0.80%) ⬆️
vm/natives/src/account.rs 12.50% <0.00%> (-12.50%) ⬇️
state/state-store-api/src/lib.rs 31.25% <0.00%> (-6.25%) ⬇️
network-rpc/core/src/lib.rs 20.00% <0.00%> (-6.00%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a055f...9405d85. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants