Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_sync_block with 1000 block gap #3558

Merged
merged 1 commit into from
Jul 22, 2022
Merged

fix_sync_block with 1000 block gap #3558

merged 1 commit into from
Jul 22, 2022

Conversation

yourmoonlight
Copy link
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently, we are syncing the blocks using a cron action.
Sometimes, the export behavior did not work as expected.
For example, we would like to export blocks from 6865515 to 6875514, but the export cmd export from 6865515 to 6875106.

Issue Number: N/A

What is the new behavior?

The export behavior will be consistent.

Other information

#3556
#3549

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #3558 (b14e630) into master (9f5d1c1) will increase coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3558      +/-   ##
==========================================
+ Coverage   29.12%   29.65%   +0.53%     
==========================================
  Files         589      589              
  Lines       49753    49753              
  Branches    23411    23411              
==========================================
+ Hits        14486    14749     +263     
+ Misses      20842    20816      -26     
+ Partials    14425    14188     -237     
Flag Coverage Δ
unittests 29.65% <ø> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config/src/helper.rs 39.22% <0.00%> (-3.92%) ⬇️
txpool/src/pool/listener/tests.rs 10.91% <0.00%> (-3.63%) ⬇️
commons/accumulator/src/tree_store/mock.rs 28.58% <0.00%> (-2.85%) ⬇️
sync/src/tasks/mock.rs 44.03% <0.00%> (-1.63%) ⬇️
config/src/account_provider_config.rs 26.99% <0.00%> (-1.58%) ⬇️
vm/types/src/token/token_value.rs 55.56% <0.00%> (-1.38%) ⬇️
storage/src/db_storage/mod.rs 40.86% <0.00%> (-1.27%) ⬇️
vm/types/src/token/token_code.rs 34.53% <0.00%> (-1.19%) ⬇️
config/src/network_config.rs 49.80% <0.00%> (-0.82%) ⬇️
...ons/forkable-jellyfish-merkle/src/node_type/mod.rs 70.17% <0.00%> (-0.67%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bbf1d4...b14e630. Read the comment docs.

@github-actions
Copy link

Benchmark for 7e1bb6b

Click to view benchmark
Test Base PR %
accumulator_append 596.9±11.44µs 589.9±10.08µs -1.17%
block_apply/block_apply_10 265.1±0.40ms 264.9±0.89ms -0.08%
block_apply/block_apply_1000 27.1±0.03s 27.0±0.03s -0.37%
get_with_proof/db_store 36.9±0.34µs 36.7±0.24µs -0.54%
get_with_proof/mem_store 31.6±0.17µs 31.7±0.17µs +0.32%
put_and_commit/db_store/1 95.1±4.86µs 94.8±4.86µs -0.32%
put_and_commit/db_store/10 861.1±41.17µs 845.7±38.38µs -1.79%
put_and_commit/db_store/100 7.4±0.32ms 7.3±0.33ms -1.35%
put_and_commit/db_store/5 439.3±22.55µs 436.5±20.71µs -0.64%
put_and_commit/db_store/50 3.9±0.17ms 3.8±0.19ms -2.56%
put_and_commit/mem_store/1 62.1±5.65µs 61.6±5.54µs -0.81%
put_and_commit/mem_store/10 581.7±46.41µs 573.6±47.68µs -1.39%
put_and_commit/mem_store/100 5.7±0.83ms 5.7±0.83ms 0.00%
put_and_commit/mem_store/5 291.9±24.24µs 290.2±24.97µs -0.58%
put_and_commit/mem_store/50 2.9±0.18ms 2.8±0.18ms -3.45%
query_block/query_block_in(10)_times(100) 3.9±0.13ms 3.9±0.10ms 0.00%
query_block/query_block_in(10)_times(1000) 38.7±0.89ms 39.0±0.88ms +0.78%
query_block/query_block_in(10)_times(10000) 389.5±7.36ms 391.8±5.20ms +0.59%
query_block/query_block_in(1000)_times(100) 953.5±17.31µs 949.6±6.87µs -0.41%
query_block/query_block_in(1000)_times(1000) 9.5±0.06ms 9.4±0.07ms -1.05%
query_block/query_block_in(1000)_times(10000) 95.4±0.73ms 94.5±0.82ms -0.94%
storage_transaction 1094.7±369.30µs 1061.3±302.39µs -3.05%
vm/transaction_execution/1 315.3±2.99ms 313.2±1.98ms -0.67%
vm/transaction_execution/10 100.5±3.24ms 98.3±0.09ms -2.19%
vm/transaction_execution/20 92.8±0.58ms 92.1±0.79ms -0.75%
vm/transaction_execution/5 121.0±0.67ms 120.1±0.56ms -0.74%
vm/transaction_execution/50 107.7±1.52ms 106.2±0.47ms -1.39%

@nkysg nkysg self-requested a review July 22, 2022 03:23
@jolestar jolestar merged commit c243e14 into master Jul 22, 2022
@jolestar jolestar deleted the fix_sync_block branch July 22, 2022 07:29
@nkysg nkysg linked an issue Jul 25, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] fail when importing block
3 participants