-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix_sync_block with 1000 block gap #3558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t 1000 lower then latest height
Codecov Report
@@ Coverage Diff @@
## master #3558 +/- ##
==========================================
+ Coverage 29.12% 29.65% +0.53%
==========================================
Files 589 589
Lines 49753 49753
Branches 23411 23411
==========================================
+ Hits 14486 14749 +263
+ Misses 20842 20816 -26
+ Partials 14425 14188 -237
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Benchmark for 7e1bb6bClick to view benchmark
|
nkysg
approved these changes
Jul 22, 2022
jolestar
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently, we are syncing the blocks using a cron action.
Sometimes, the export behavior did not work as expected.
For example, we would like to export blocks from 6865515 to 6875514, but the export cmd export from 6865515 to 6875106.
Issue Number: N/A
What is the new behavior?
The export behavior will be consistent.
Other information
#3556
#3549