-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[transaction-builder-generator] fix package name for Java and change diem to startcoin, and update readme #3555
[transaction-builder-generator] fix package name for Java and change diem to startcoin, and update readme #3555
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3555 +/- ##
==========================================
+ Coverage 29.02% 29.27% +0.25%
==========================================
Files 589 589
Lines 49864 49864
Branches 23450 23450
==========================================
+ Hits 14468 14592 +124
- Misses 21179 21233 +54
+ Partials 14217 14039 -178
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6d09c36
to
96c4f32
Compare
做了些文档,java包名,cli参数名字的修改,但是目前demo还是跑不起来。 |
96c4f32
to
8dc2163
Compare
8dc2163
to
1651446
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
But I don't know if we still need this crate.
cc @jolestar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有测试么,生成的代码执行都没问题么?原来有个各语言的测试,但依赖环境比较复杂就没有继续运行。感觉未来可以把这个集成到 mpm 中,第三方应用也可以用来生成代码。
现在生成的sdk代码感觉还有不少问题,需要长期比较耐心的调整 |
那先合并进去吧 |
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
#3554
#3469
What is the new behavior?
Other information