Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[transaction-builder-generator] fix package name for Java and change diem to startcoin, and update readme #3555

Conversation

jiangying000
Copy link
Collaborator

@jiangying000 jiangying000 commented Jul 21, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A
#3554
#3469

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #3555 (1651446) into master (d216459) will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3555      +/-   ##
==========================================
+ Coverage   29.02%   29.27%   +0.25%     
==========================================
  Files         589      589              
  Lines       49864    49864              
  Branches    23450    23450              
==========================================
+ Hits        14468    14592     +124     
- Misses      21179    21233      +54     
+ Partials    14217    14039     -178     
Flag Coverage Δ
unittests 29.27% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sync/src/block_connector/test_write_block_chain.rs 26.36% <0.00%> (-3.87%) ⬇️
sync/src/block_connector/write_block_chain.rs 26.16% <0.00%> (-3.07%) ⬇️
commons/accumulator/src/tree_store/mock.rs 28.58% <0.00%> (-2.85%) ⬇️
vm/natives/src/token.rs 28.89% <0.00%> (-2.22%) ⬇️
commons/service-registry/src/handler_proxy.rs 38.55% <0.00%> (-2.08%) ⬇️
storage/src/lib.rs 54.36% <0.00%> (-2.07%) ⬇️
config/src/helper.rs 39.22% <0.00%> (-1.96%) ⬇️
storage/src/block/mod.rs 54.77% <0.00%> (-1.78%) ⬇️
sync/src/block_connector/test_illegal_block.rs 16.00% <0.00%> (-1.73%) ⬇️
vm/types/src/token/stc.rs 63.24% <0.00%> (-1.47%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d216459...1651446. Read the comment docs.

@jiangying000 jiangying000 force-pushed the transaction-builder-generator-update branch 2 times, most recently from 6d09c36 to 96c4f32 Compare August 4, 2022 08:49
@jiangying000 jiangying000 changed the title [transaction-builder-generator] fix transaction-builder-generator for Java and update readme [transaction-builder-generator] fix some package name for Java and update readme Aug 4, 2022
@jiangying000 jiangying000 changed the title [transaction-builder-generator] fix some package name for Java and update readme [transaction-builder-generator] fix package name for Java and change diem to startcoin, and update readme Aug 4, 2022
@jiangying000 jiangying000 marked this pull request as ready for review August 4, 2022 10:33
@jiangying000 jiangying000 requested a review from nanne007 as a code owner August 4, 2022 10:33
@jiangying000
Copy link
Collaborator Author

做了些文档,java包名,cli参数名字的修改,但是目前demo还是跑不起来。

@jiangying000 jiangying000 force-pushed the transaction-builder-generator-update branch from 96c4f32 to 8dc2163 Compare August 4, 2022 11:16
@jiangying000 jiangying000 force-pushed the transaction-builder-generator-update branch from 8dc2163 to 1651446 Compare August 4, 2022 11:26
Copy link
Member

@nanne007 nanne007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
But I don't know if we still need this crate.

@nanne007
Copy link
Member

nanne007 commented Aug 4, 2022

cc @jolestar

Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有测试么,生成的代码执行都没问题么?原来有个各语言的测试,但依赖环境比较复杂就没有继续运行。感觉未来可以把这个集成到 mpm 中,第三方应用也可以用来生成代码。

@jiangying000
Copy link
Collaborator Author

有测试么,生成的代码执行都没问题么?原来有个各语言的测试,但依赖环境比较复杂就没有继续运行。感觉未来可以把这个集成到 mpm 中,第三方应用也可以用来生成代码。

现在生成的sdk代码感觉还有不少问题,需要长期比较耐心的调整

@jolestar
Copy link
Member

jolestar commented Aug 4, 2022

有测试么,生成的代码执行都没问题么?原来有个各语言的测试,但依赖环境比较复杂就没有继续运行。感觉未来可以把这个集成到 mpm 中,第三方应用也可以用来生成代码。

现在生成的sdk代码感觉还有不少问题,需要长期比较耐心的调整

那先合并进去吧

@jolestar jolestar linked an issue Aug 4, 2022 that may be closed by this pull request
@jiangying000 jiangying000 merged commit 1f5445f into starcoinorg:master Aug 4, 2022
@jolestar jolestar linked an issue Aug 4, 2022 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dev] Improvement code generator for sdk [Bug Report] transaction-builder-generator generate broken Source
3 participants