Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy update_move branch to proxima #3546

Merged
merged 2 commits into from
Jul 20, 2022
Merged

deploy update_move branch to proxima #3546

merged 2 commits into from
Jul 20, 2022

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Jul 18, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

update_move branch deploy to halley

Issue Number: N/A

What is the new behavior?

Other information

@nkysg nkysg requested a review from jolestar July 18, 2022 14:57
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #3546 (4de3385) into master (29cf2b5) will decrease coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3546      +/-   ##
==========================================
- Coverage   29.61%   29.01%   -0.60%     
==========================================
  Files         589      589              
  Lines       49753    49753              
  Branches    23420    23411       -9     
==========================================
- Hits        14731    14429     -302     
- Misses      20810    20999     +189     
- Partials    14212    14325     +113     
Flag Coverage Δ
unittests 29.01% <ø> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test-helper/src/dummy_network_service.rs 22.23% <0.00%> (-14.81%) ⬇️
vm/types/src/on_chain_config/mod.rs 38.36% <0.00%> (-13.69%) ⬇️
vm/natives/src/token.rs 17.78% <0.00%> (-13.33%) ⬇️
vm/types/src/language_storage_ext.rs 29.17% <0.00%> (-12.50%) ⬇️
vm/natives/src/account.rs 12.50% <0.00%> (-12.50%) ⬇️
vm/natives/src/lib.rs 80.00% <0.00%> (-10.00%) ⬇️
vm/types/src/on_chain_config/vm_config.rs 35.00% <0.00%> (-10.00%) ⬇️
executor/src/block_executor.rs 25.59% <0.00%> (-9.30%) ⬇️
chain/open-block/src/lib.rs 31.79% <0.00%> (-9.27%) ⬇️
vm/types/src/transaction_metadata.rs 55.23% <0.00%> (-8.95%) ⬇️
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29cf2b5...4de3385. Read the comment docs.

@github-actions
Copy link

Benchmark for bc9063d

Click to view benchmark
Test Base PR %
accumulator_append 589.0±11.70µs 594.1±13.19µs +0.87%
block_apply/block_apply_10 264.9±0.73ms 264.1±0.45ms -0.30%
block_apply/block_apply_1000 27.1±0.19s 26.9±0.02s -0.74%
get_with_proof/db_store 37.0±0.33µs 36.3±0.23µs -1.89%
get_with_proof/mem_store 31.9±0.18µs 31.2±0.19µs -2.19%
put_and_commit/db_store/1 94.4±4.71µs 94.2±4.69µs -0.21%
put_and_commit/db_store/10 851.6±38.28µs 852.4±39.19µs +0.09%
put_and_commit/db_store/100 7.3±0.30ms 7.3±0.31ms 0.00%
put_and_commit/db_store/5 433.3±21.80µs 434.3±21.31µs +0.23%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.18ms 0.00%
put_and_commit/mem_store/1 61.6±5.71µs 61.4±5.62µs -0.32%
put_and_commit/mem_store/10 573.8±47.25µs 578.5±48.83µs +0.82%
put_and_commit/mem_store/100 5.6±0.34ms 5.7±0.82ms +1.79%
put_and_commit/mem_store/5 289.5±24.94µs 290.6±25.26µs +0.38%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.09ms 3.8±0.11ms -2.56%
query_block/query_block_in(10)_times(1000) 38.7±1.03ms 39.0±1.07ms +0.78%
query_block/query_block_in(10)_times(10000) 391.5±6.39ms 385.2±7.03ms -1.61%
query_block/query_block_in(1000)_times(100) 960.8±13.32µs 948.1±6.98µs -1.32%
query_block/query_block_in(1000)_times(1000) 9.5±0.08ms 9.5±0.22ms 0.00%
query_block/query_block_in(1000)_times(10000) 95.1±0.57ms 94.7±0.23ms -0.42%
storage_transaction 1043.3±298.31µs 1059.6±302.55µs +1.56%
vm/transaction_execution/1 311.2±0.72ms 311.8±1.72ms +0.19%
vm/transaction_execution/10 98.7±1.50ms 98.0±0.14ms -0.71%
vm/transaction_execution/20 91.6±0.22ms 91.4±0.34ms -0.22%
vm/transaction_execution/5 119.7±0.44ms 119.5±0.32ms -0.17%
vm/transaction_execution/50 106.2±1.48ms 106.3±1.41ms +0.09%

@jolestar
Copy link
Member

要不 Move table 这个用 proxima 网络来测试?halley 这个每次会自动部署,用来测试 DAO 吧,合约部分 DAO 变化比较大。 @nkysg @yourmoonlight @muzixinly

@nkysg
Copy link
Collaborator Author

nkysg commented Jul 19, 2022

要不 Move table 这个用 proxima 网络来测试?halley 这个每次会自动部署,用来测试 DAO 吧,合约部分 DAO 变化比较大。 @nkysg @yourmoonlight @muzixinly

OK

@baichuan3
Copy link

要不 Move table 这个用 proxima 网络来测试?halley 这个每次会自动部署,用来测试 DAO 吧,合约部分 DAO 变化比较大。 @nkysg @yourmoonlight @muzixinly

Move table和DAO同时在proxima上测试冲突不

@jolestar
Copy link
Member

要不 Move table 这个用 proxima 网络来测试?halley 这个每次会自动部署,用来测试 DAO 吧,合约部分 DAO 变化比较大。 @nkysg @yourmoonlight @muzixinly

Move table和DAO同时在proxima上测试冲突不

冲突,所以 DAO 用 halley 来测试

@nkysg nkysg changed the title deploy update_move branch to halley deploy update_move branch to proxima Jul 20, 2022
@nkysg
Copy link
Collaborator Author

nkysg commented Jul 20, 2022

use proxima net

@jolestar jolestar merged commit 7bbf1d4 into master Jul 20, 2022
@jolestar jolestar deleted the update_halley branch July 20, 2022 09:09
jiangying000 pushed a commit to jiangying000/starcoin that referenced this pull request Jul 22, 2022
* deploy update_move branch to halley

* proxima use update_move branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants