Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3527 allow dev deploy deploy the package to another address #3528

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Fix #3527 allow dev deploy deploy the package to another address #3528

merged 3 commits into from
Jul 13, 2022

Conversation

WGB5445
Copy link
Contributor

@WGB5445 WGB5445 commented Jul 13, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

When i want to deploy the module for the Dao account, the module cannot be deployed normally because the sender and the sender in the blob are different.

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #3528 (bfef329) into master (24457a9) will increase coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3528      +/-   ##
==========================================
+ Coverage   29.40%   29.53%   +0.13%     
==========================================
  Files         589      589              
  Lines       49740    49739       -1     
  Branches    23405    23404       -1     
==========================================
+ Hits        14623    14687      +64     
+ Misses      20956    20860      -96     
- Partials    14161    14192      +31     
Flag Coverage Δ
unittests 29.53% <0.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/starcoin/src/dev/deploy_cmd.rs 0.00% <0.00%> (ø)
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.66%) ⬇️
test-helper/src/dummy_network_service.rs 22.23% <0.00%> (-14.81%) ⬇️
vm/types/src/transaction/error.rs 3.58% <0.00%> (-7.14%) ⬇️
chain/src/verifier/mod.rs 33.81% <0.00%> (-7.04%) ⬇️
consensus/src/consensus.rs 55.56% <0.00%> (-4.76%) ⬇️
config/src/helper.rs 41.18% <0.00%> (-3.92%) ⬇️
sync/src/block_connector/test_write_block_chain.rs 31.79% <0.00%> (-3.10%) ⬇️
vm/transaction-builder/src/lib.rs 24.94% <0.00%> (-2.20%) ⬇️
types/src/block.rs 56.16% <0.00%> (-2.13%) ⬇️
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24457a9...bfef329. Read the comment docs.

@jolestar jolestar merged commit 521eabd into starcoinorg:master Jul 13, 2022
jiangying000 pushed a commit to jiangying000/starcoin that referenced this pull request Jul 22, 2022
…ddress (starcoinorg#3528)

* Fix starcoinorg#3527 allow dev deploy deploy the package to another address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow dev deploy deploy the package to another address
3 participants