Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-version compatibility check #3522

Merged
merged 1 commit into from
Jul 16, 2022
Merged

pre-version compatibility check #3522

merged 1 commit into from
Jul 16, 2022

Conversation

yuliyu123
Copy link
Contributor

@yuliyu123 yuliyu123 commented Jul 8, 2022

Add a --pre-modules option to mpm check-compatibility to check compatibility between the current version and the previous version.

usage:
mpm check-compatibility --pre-modules release/BasicCoin.v0.0.0.blob/BasicCoin.v0.0.0.blob

@yuliyu123 yuliyu123 requested a review from nanne007 as a code owner July 8, 2022 12:14
@yuliyu123 yuliyu123 marked this pull request as draft July 8, 2022 12:14
@yuliyu123 yuliyu123 marked this pull request as ready for review July 13, 2022 11:08
@yuliyu123
Copy link
Contributor Author

hi @jolestar @nkysg, please review this ticket, thanks.

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #3522 (9a81b43) into master (7a81c7d) will increase coverage by 0.17%.
The diff coverage is 0.00%.

❗ Current head 9a81b43 differs from pull request most recent head 7738f3e. Consider uploading reports for the commit 7738f3e to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3522      +/-   ##
==========================================
+ Coverage   29.39%   29.56%   +0.17%     
==========================================
  Files         589      589              
  Lines       49739    49753      +14     
  Branches    23404    23417      +13     
==========================================
+ Hits        14618    14703      +85     
+ Misses      20845    20785      -60     
+ Partials    14276    14265      -11     
Flag Coverage Δ
unittests 29.56% <0.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/starcoin/src/dev/dev_helper.rs 0.00% <0.00%> (ø)
consensus/src/dummy.rs 65.22% <0.00%> (-8.69%) ⬇️
chain/src/verifier/mod.rs 34.51% <0.00%> (-5.63%) ⬇️
state/state-tree/src/mock/mod.rs 39.14% <0.00%> (-4.34%) ⬇️
vm/natives/src/vector.rs 20.84% <0.00%> (-4.16%) ⬇️
consensus/src/consensus.rs 55.56% <0.00%> (-3.17%) ⬇️
config/src/account_provider_config.rs 25.40% <0.00%> (-3.17%) ⬇️
sync/src/block_connector/metrics.rs 24.25% <0.00%> (-3.03%) ⬇️
sync/src/block_connector/test_write_block_chain.rs 33.34% <0.00%> (-2.32%) ⬇️
config/src/rpc_config.rs 42.60% <0.00%> (-2.16%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a81c7d...7738f3e. Read the comment docs.

@yuliyu123 yuliyu123 requested review from jolestar and nkysg July 16, 2022 00:39
@nkysg nkysg merged commit 9349f09 into starcoinorg:master Jul 16, 2022
@nkysg nkysg linked an issue Jul 18, 2022 that may be closed by this pull request
jiangying000 pushed a commit to jiangying000/starcoin that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] mpm support check compatibility from previous package
3 participants