Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mpm] Integration test support multi sign address #3449

Merged
merged 3 commits into from
Jun 10, 2022

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Jun 8, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Support set MultiSig public key in integration test init args

Other information

@jolestar jolestar requested review from nanne007 and LemonHX June 8, 2022 08:54
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #3449 (f3b53cf) into master (1c4190b) will increase coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3449      +/-   ##
==========================================
+ Coverage   32.49%   32.55%   +0.06%     
==========================================
  Files         500      500              
  Lines       46805    46806       +1     
  Branches    21301    21302       +1     
==========================================
+ Hits        15206    15234      +28     
+ Misses      17687    17539     -148     
- Partials    13912    14033     +121     
Flag Coverage Δ
unittests 32.55% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/starcoin-transactional-test-harness/src/lib.rs 0.19% <0.00%> (-<0.01%) ⬇️
consensus/src/consensus.rs 44.45% <0.00%> (-17.46%) ⬇️
consensus/src/dummy.rs 69.57% <0.00%> (-17.39%) ⬇️
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.66%) ⬇️
test-helper/src/dummy_network_service.rs 22.23% <0.00%> (-14.81%) ⬇️
vm/types/src/transaction/error.rs 3.58% <0.00%> (-10.71%) ⬇️
state/state-tree/src/mock/mod.rs 43.48% <0.00%> (-8.69%) ⬇️
cmd/starcoin/src/cli_state.rs 48.79% <0.00%> (-4.87%) ⬇️
vm/types/src/transaction_metadata.rs 61.20% <0.00%> (-4.47%) ⬇️
executor/src/executor.rs 50.00% <0.00%> (-4.16%) ⬇️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4190b...f3b53cf. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Benchmark for 433bac4

Click to view benchmark
Test Base PR %
accumulator_append 583.9±10.73µs 588.1±10.49µs +0.72%
block_apply/block_apply_10 263.0±0.51ms 264.3±1.05ms +0.49%
block_apply/block_apply_1000 26.9±0.04s 27.0±0.04s +0.37%
get_with_proof/db_store 36.2±0.23µs 36.1±0.21µs -0.28%
get_with_proof/mem_store 31.6±0.60µs 31.4±1.07µs -0.63%
put_and_commit/db_store/1 95.9±4.92µs 95.4±4.71µs -0.52%
put_and_commit/db_store/10 857.2±39.47µs 855.2±38.41µs -0.23%
put_and_commit/db_store/100 7.4±0.32ms 7.3±0.30ms -1.35%
put_and_commit/db_store/5 439.9±23.08µs 435.3±21.96µs -1.05%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.18ms 0.00%
put_and_commit/mem_store/1 62.4±5.60µs 61.5±5.70µs -1.44%
put_and_commit/mem_store/10 581.1±46.99µs 574.0±46.58µs -1.22%
put_and_commit/mem_store/100 5.7±0.82ms 5.6±0.81ms -1.75%
put_and_commit/mem_store/5 294.3±25.20µs 288.7±24.49µs -1.90%
put_and_commit/mem_store/50 2.9±0.19ms 2.8±0.18ms -3.45%
query_block/query_block_in(10)_times(100) 3.8±0.14ms 3.8±0.14ms 0.00%
query_block/query_block_in(10)_times(1000) 38.5±1.21ms 39.2±0.81ms +1.82%
query_block/query_block_in(10)_times(10000) 387.4±6.16ms 387.3±6.70ms -0.03%
query_block/query_block_in(1000)_times(100) 933.8±5.92µs 979.8±7.68µs +4.93%
query_block/query_block_in(1000)_times(1000) 9.4±0.09ms 9.9±0.10ms +5.32%
query_block/query_block_in(1000)_times(10000) 93.5±0.66ms 98.0±0.88ms +4.81%
storage_transaction 1055.0±296.74µs 1044.9±274.85µs -0.96%
vm/transaction_execution/1 312.0±0.74ms 313.7±1.07ms +0.54%
vm/transaction_execution/10 98.4±0.53ms 99.0±0.29ms +0.61%
vm/transaction_execution/20 93.1±3.30ms 92.3±0.66ms -0.86%
vm/transaction_execution/5 120.7±1.64ms 120.7±0.97ms 0.00%
vm/transaction_execution/50 106.0±0.31ms 106.8±1.23ms +0.75%

@jolestar jolestar enabled auto-merge (squash) June 9, 2022 01:16
@jolestar jolestar disabled auto-merge June 9, 2022 01:16
@jolestar jolestar enabled auto-merge (squash) June 9, 2022 01:17
@jolestar jolestar requested a review from templexxx June 10, 2022 01:50
@jolestar jolestar merged commit ff3734e into master Jun 10, 2022
@jolestar jolestar deleted the integration_test_multikey branch June 10, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants