Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pbkdf2 from 0.3.0 to 0.11.0 #3340

Merged

Conversation

uvd
Copy link
Contributor

@uvd uvd commented Apr 13, 2022

Bump pbkdf2 from 0.3.0 to 0.11.0## Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #3318

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #3340 (8f61b40) into master (d07e82d) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3340      +/-   ##
==========================================
+ Coverage   31.86%   32.06%   +0.21%     
==========================================
  Files         500      500              
  Lines       46785    46785              
  Branches    21228    21236       +8     
==========================================
+ Hits        14902    14996      +94     
- Misses      17808    17825      +17     
+ Partials    14075    13964     -111     
Flag Coverage Δ
unittests 32.06% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commons/decrypt/src/lib.rs 70.00% <100.00%> (ø)
...m/types/src/account_config/events/config_change.rs 66.67% <0.00%> (-33.33%) ⬇️
vm/natives/src/account.rs 12.50% <0.00%> (-18.75%) ⬇️
...mons/forkable-jellyfish-merkle/src/iterator/mod.rs 41.00% <0.00%> (-4.00%) ⬇️
consensus/src/difficulty.rs 41.18% <0.00%> (-3.52%) ⬇️
...s/forkable-jellyfish-merkle/src/mock_tree_store.rs 34.49% <0.00%> (-3.44%) ⬇️
vm/natives/src/token.rs 26.67% <0.00%> (-2.22%) ⬇️
network-p2p/src/protocol.rs 43.11% <0.00%> (-2.06%) ⬇️
node/src/node.rs 10.49% <0.00%> (-1.74%) ⬇️
vm/types/src/token/token_value.rs 58.34% <0.00%> (-1.38%) ⬇️
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d07e82d...8f61b40. Read the comment docs.

@jolestar jolestar requested a review from nanne007 April 13, 2022 11:44
Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jolestar jolestar linked an issue Apr 13, 2022 that may be closed by this pull request
@jolestar jolestar merged commit 9d7fad3 into starcoinorg:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dev] Bump pbkdf2 from 0.3.0 to 0.11.0
3 participants