-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report] state.list_resource resource_types filter do not work use short address. #3612
Comments
@jiangying000 #3586 这个实现好像有点问题 |
working on it |
当时想的是先实现最严格的Addr::Module::StructTag完全版字符串的匹配,后续根据实际需求做修改 resource_types内部实现改一下就可以支持各类级别的筛选,短地址0x1,支持仅地址0x005c80,支持模块0x5588::Abc,支持带泛型0x1::22bc::XXY<A,B>,应该都是改下都可以了 当时没想到要手打地址的场景😂,以为就是前端调api的时候写死在代码里面的 |
@YusongWang 你要做的话,和 @jiangying000 沟通一下想法 |
@jiangying000 #3615 看下这里。只对address进行了匹配。看了你说的,估计你做的方法应该更普遍合适一些,可以转给你做。 |
感觉需要解析一下地址,通过解析后的类型去比较,而不是字符串匹配,可以和 #3614 的方案一起考虑下。 |
Bug Report
Starcoin version:
latest
Current behavior:
Expected behavior:
"resource_types":["0x1::Account::Balance"] == "resource_types":["0x00000000000000000000000000000001::Account::Balance"]}]
Steps to reproduce:
Related code:
starcoin/rpc/server/src/module/state_rpc.rs
Lines 279 to 287 in 8aa6bf2
Other information:
The text was updated successfully, but these errors were encountered: