Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pydantic to ^2.6 #570

Closed
mwildehahn opened this issue Mar 6, 2024 · 5 comments
Closed

Upgrade pydantic to ^2.6 #570

mwildehahn opened this issue Mar 6, 2024 · 5 comments

Comments

@mwildehahn
Copy link
Contributor

The project is pinned to pydantic 2.5.0. Any reason it can't be upgraded to the latest version ^2.6?

@isaacbmiller
Copy link
Collaborator

There used to be tests with the pydantic version name in them, but those seem to have been removed. IMO good to upgrade but I would defer to @thomasahle

@thomasahle
Copy link
Collaborator

Yes, I fixed those tests.
I'm happy to upgrade pydantic if the tests pass.

@nlaffey
Copy link

nlaffey commented Apr 6, 2024

👀 I'm also needing pydnatic at 2.6 so that I can generate an OpenApi 3.1 spec

@thomasahle
Copy link
Collaborator

Yes, I don't see any reason to now upgrade. I don't think we are using any newer features though, so maybe we can just put the requirement pydantic >= 2.0?

@Shakakai
Copy link

Yes, I don't see any reason to now upgrade. I don't think we are using any newer features though, so maybe we can just put the requirement pydantic >= 2.0?

Yeah, just want to say that I'd really appreciate if the version wasn't pinned to 2.5.0 but allowed for a range of versions pydantic >= 2.5.0. I can only use the library in side projects because of that pinned version requirement. Everything I use these days relies on pydantic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants