Proposal: Update rubocop and handles a new cop #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also see problems with the current 1.66 Rubocop version. This is because of the latest update of psych. Resulting in errors like See: rubocop/rubocop#11060 (comment) This should be fixed when upgrading to 1.68.0 as this PR has made in to that version already: rubocop/rubocop#13379 I added a PR updating to 1.68 already: #659 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v1.67.0, the
AllowRBSInlineAnnotationconfig option has been added to theLayout/LeadingCommentSpacecop.It is necessary to annotate types in Ruby code via RBS::Inline. RBS::Inline is a pilot project of ruby/rbs and is planned to be merged into ruby/rbs.
Could you update rubocop to v1.67.0 and enable the
AllowRBSInlineAnnotationoption, please?