Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generating todo when todo file already exists #587

Merged
merged 10 commits into from
Dec 4, 2023
Merged

Fix generating todo when todo file already exists #587

merged 10 commits into from
Dec 4, 2023

Commits on Jul 10, 2023

  1. Fix bug with generating a new todo file when one exists already.

    This commit refactors the `builds_config.rb` file to handle generating a new todo file. It adds logic to not load the existing todo file when generating a new one, ensuring that the new todo file includes all necessary ignore rules from scratch.
    mrbiggred committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    ba1b01f View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Remove redundant test for merging ignore rules in config and todo fil…

    …e rules.
    
    - Update `BuildsConfigTest` to remove the `test_todo_merged` method
    - Removed fixture "u" files.
    mrbiggred committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    a9659c0 View commit details
    Browse the repository at this point in the history
  2. Add test for not loading todo file when generating todo file

    This commit adds a new test case to ensure that the todo file is not loaded when generating the todo file.
    mrbiggred committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    566042f View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. Refactor todo file loading logic and update related test

    - Refactored the code to use `unless` instead of checking if `argv` does not include "--generate-todo"
    - Refactored the test to remove unneeded expected value setup.
    mrbiggred committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    e413549 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Add system test for --generate-todo flag

    The commit adds a new test to check whether standardrb's '--generate-todo' generates the correct todo file.
    mrbiggred committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    68e77e1 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Added system test for when a todo file already exists.

    New test case is introduced to validate the to-do list generation when one already exists. It ensures that existing errors will not obstruct the to-do list generation and will be duly reported.
    mrbiggred committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    45ebde6 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Refactor test setup and generate_todo_existing in StandardrbTest

    - Refactored the before_setup method to include additional setup steps.
    - Updated the generate_todo_existing test to use a separate test folder and fixture folder for better organization.
    - Modified file paths in the generate_todo_existing test to reflect the new folder structure.
    mrbiggred committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    cd1d59f View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Refactor the generate todo file tests.

    - Refactored the `test_generate_todo` and `test_generate_todo_existing` methods in the `StandardrbTest` class to use a new helper function called `assert_generate_todo`.
    mrbiggred committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    b189635 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Configuration menu
    Copy the full SHA
    2688546 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf8eb75 View commit details
    Browse the repository at this point in the history