Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement tags folder as experimental feature #788

Merged
merged 6 commits into from
Dec 23, 2021
Merged

feat: implement tags folder as experimental feature #788

merged 6 commits into from
Dec 23, 2021

Conversation

laurentsenta
Copy link
Contributor

  • add drag and drops for folders,
  • fold / unfold
  • implement the check for parents,
  • make the UI nicer, especially the "root dropzone",
  • use a flag to activate as a paid option,
  • check renaming rejection (clear title)
  • refactor the code for maintainability
      • move feature-related state (paid tag nesting, etc) to another app_state component
    • move tag-state related code to the tag_state.ts file
    • => It'll be easier to do this when we refactor the smart tag feature too, we'll just unify the whole state into this tag_state.
  • Reuse the modal with Premium messages
  • Decide once and for all if we use "tag folders", "tag nesting", or "folders" in the copy.

laurentsenta and others added 6 commits December 23, 2021 09:24
@laurentsenta
feat: add tag folders support basics
a288d73 
* feat: add draggability to tags

* feat: add drag & drop draft

* feat: fold folders

* fix: do not select on fold / unfold tags

* style: clean the isValidTag call

* feat: add native folder toggle

* feat: add touch mobile support

* ui: add nicer design & icons

* style: render full-width tag items

* feat: nicer looking dropzone

* style: fix arguments

* fix: tag template rendering in list items

* feat: tag can be dragged over the whole item

* fix: cancel / reset title after save

* fix: disable drag completely when needed

* fix: invalid tag parents

* feat: add paying feature

* feat: with paid feature tooltip

* feat: tag has a plus feature

* feat: add premium modal

* style: simplif code

* refactor: extract feature_state & simplif code

* fix: icons and icons svg

* style: remove comment

* feat: tag folders naming

* feat: use the feature notification

* fix: tag folders copy

* style: variable names

* style: remove & clean comments

* refactor: remove is-mobile library
@laurentsenta
feat: tags folder experimental (#10)
38ff3c6 
* feat: hide native folders behind experimental flag

* fix: better tags resizing

* fix: merge global window

* style: rename params

* refactor: remove level of indirection in feature toggle
@laurentsenta
feat: recursively add tags to note on create (#9)
c2b6168
@laurentsenta
fix: use add tags folder hierarchy & isTemplateItem (#13)
592cd88 
* fix: use new snjs add tag hierarchy

* fix: use new snjs isTemplateItem
@laurentsenta @moughxyz
feat: tags folder premium (#774)
394049b 
* feat: upgrade premium in tags section

refactor: move TagsSection to react

feat: show premium on Tag section

feat: keep drag and drop features always active

fix: drag & drop tweak with premium

feat: premium messages

fix: remove fill in svg icons

fix: change tag list color (temporary)

style: remove dead code

refactor: clarify names and modules

fix: draggable behind feature toggle

feat: add button in TagSection & design

* feat: fix features loading with app state (#775)

* fix: distinguish between app launch and start

* fix: update state for footer too

* fix: wait for application launch event

Co-authored-by: Laurent Senta <[email protected]>

* feat: tags folder with folder text design (#776)

* feat: add folder text

* fix: sn stylekit colors

* fix: root drop zone

* chore: upgrade stylekit

* fix: hide dropzone when feature is disabled

* chore: bump versions now that they are released

Co-authored-by: Mo <[email protected]>
@laurentsenta
feat: tags folder design review (#785)
01e3e9e 
* fix: upgrade design after review

* fix: tweak dropzone

* fix: sync after assign parent

* fix: tsc error on build

* fix: vertical center the fold arrows

* fix: define our own hoist for react-dnd

* feat: hide fold when there are no folders

* fix: show children usability + resize UI

* fix: use old colors for now, theme compat

* fix: tweak alignment and add title

* fix: meta offset with folders

* fix: tweak tag size

* fix: observable setup

* fix: use link-off icon on dropzone

* fix: more tweak on text sizes
@laurentsenta laurentsenta changed the title feat: implement tags folder feat: implement tags folder as experimental feature Dec 23, 2021
@laurentsenta laurentsenta merged commit 237cd91 into develop Dec 23, 2021
@laurentsenta laurentsenta deleted the feat/tags-folder branch December 23, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moughxyz moughxyz moughxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurentsenta @moughxyz