feat: handle unprotected session expiration #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… note is open and wasn't edited for a while
…ain advanced editors
…e stays selected, show its contents in the editor
…he logic to web client)
…note # Conflicts: # package.json
…note # Conflicts: # app/assets/javascripts/views/editor/editor_view.ts
- don't rely on user signed-in/out status to require authentication for protected note - remove unnecessary async/awaits - better wording on ui
- use snjs method to check if "Don't remember" option is selected in authentication modal - move the constant to snjs - fix eslint error
…ting by interval in spite of edits)
…button on hover/focus
…note # Conflicts: # package.json # yarn.lock
moughxyz
reviewed
Dec 20, 2021
moughxyz
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal links:
https://app.asana.com/0/1200588672119490/1201382347168573
https://app.asana.com/0/1200588672119490/1201525222585961