feat: Add quick settings menu with theme switcher and other changes #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moughxyz
reviewed
Oct 10, 2021
app/assets/javascripts/ui_models/app_state/quick_settings_state.ts
Outdated
Show resolved
Hide resolved
…e.ts Co-authored-by: Mo Bitar <[email protected]>
feat: Move layerable themes to bottom
feat: Handle "Escape" key feat: Make menu button look consistent to quick settings menu
amanharwara
changed the title
antsgar
approved these changes
Oct 13, 2021
Comment on lines
71
to
75
| const items: NodeListOf<HTMLButtonElement> = | ||
| accountMenuRef.current.querySelectorAll('.sn-dropdown-item'); | ||
| const currentFocusedIndex = Array.from(items).findIndex( | ||
| (btn) => btn === document.activeElement | ||
| ); |
There was a problem hiding this comment.
A more React-ish way of doing this would be to have an array of refs, a state variable specifying the currentFocusedIndex and a useEffect hook that would focus the right ref whenever the focused index state variable changes
There was a problem hiding this comment.
I've implemented this in commit 5219013, but I am facing a weird issue - the "Sign out" button gets focused by default as it gets pushed to the array before "Account settings" does. Ideally, "Account settings" would be focused by default, but I'm not sure what the best way to do that would be with this refs array implementation.
app/assets/javascripts/ui_models/app_state/quick_settings_state.ts
Outdated
Show resolved
Hide resolved
…e.ts Co-authored-by: Antonella Sgarlatta <[email protected]>
Co-authored-by: Antonella Sgarlatta <[email protected]>
… feat/theme-switcher
moughxyz
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a quick settings menu with a theme switcher when there are themes available, otherwise it directly opens the Preferences screen.
Theme Switcher:
Other changes: