feat: preferences help & feedback #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gorjan5sk
commented
Jul 8, 2021
gorjan5sk
commented
- Implement "Help & feedback page" in Preferences
- Implement reusable components for Preferences screen
gorjan5sk
force-pushed
the
feature/preferences-help-feedback
branch
from
49caf56 to
f65072b
Compare
antsgar
reviewed
Jul 8, 2021
| </a>{' '} | ||
| before advocating for a feature request. | ||
| </p> | ||
| <button |
There was a problem hiding this comment.
Since this opens a different page, for accessibility and semantic HTML this should be an a element styled as a button
There was a problem hiding this comment.
Done, now all buttons are links :)
| Want to share your feedback with us? Join the Standard Notes Slack | ||
| group for discussions on security, themes, editors and more. | ||
| </p> | ||
| <button |
| <PreferencesSegment> | ||
| <h2>Account related issue?</h2> | ||
| <p>Send an email to [email protected] and we’ll sort it out.</p> | ||
| <button |
| @@ -44,3 +45,38 @@ | |||
| @extend .color-info; | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
If we continued with the zero-client-CSS approach of utility-first classes, all of these should either belong on StyleKit as more generic reusable classes or on the HTML markup, without using extend
There was a problem hiding this comment.
I've removed the component classes. Created separate components and used utility classes as an interim solution until we decide.
antsgar
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.