Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reload when firefox pinned tab becomes visible #535

Merged
merged 2 commits into from
Mar 22, 2021
Merged

fix: reload when firefox pinned tab becomes visible #535

merged 2 commits into from
Mar 22, 2021

Conversation

moughxyz
Copy link
Member

@moughxyz moughxyz commented Mar 19, 2021 •
edited
Loading

@baptiste-grob please merge after approve.

@moughxyz moughxyz requested a review from arielsvg March 19, 2021 12:52
@arielsvg
Copy link
Contributor

arielsvg commented Mar 22, 2021 •
edited
Loading

Unless I'm missing something, this would reload the tab every time the user switched back to it?

@moughxyz
Copy link
Member Author

reloadHiddenFirefoxTab is called only on application launch. If the application is launched and the document is hidden, a visibility observer is added. Once the document is visible it will reload the page (thus deregistering the observer). Then the application starts again and this time does not enter into the reloadHiddenFirefoxTab flow.

@arielsvg
Copy link
Contributor

Aah ok, gotcha!

@arielsvg arielsvg merged commit cf76e1b into develop Mar 22, 2021
@arielsvg arielsvg deleted the firefox-fix branch March 22, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielsvg arielsvg arielsvg approved these changes

Assignees

@arielsvg arielsvg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moughxyz @arielsvg