Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce number of steps needed to get going for local development #454

Merged
merged 3 commits into from
Sep 2, 2020

Conversation

arielsvg
Copy link
Contributor

Using a combination of .env files and a webpack html template with sensible defaults makes for the most straightforward development quick-start experience possible

@arielsvg arielsvg requested a review from moughxyz August 27, 2020 17:00
index.html Show resolved Hide resolved
package.json Outdated
"start": "webpack-dev-server --progress --config webpack.dev.js",
"watch": "webpack -w --config webpack.dev.js",
"bundle": "webpack --config webpack.prod.js",
"build": "bundle install && npm ci && bundle exec rails assets:precompile && npm run bundle",
"submodules": "git submodule update --init --force --remote",
"submodules": "git submodule update --init",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found without force remote it struggles to pull changes to submodules sometimes. Might be good to just keep this if it's generally harmless.

Copy link
Contributor Author

@arielsvg arielsvg Sep 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem with --remote is that it actually updates the submodule's HEAD to the repo's latest commit which in many cases is not what we want.
I could keep --force in though.

@arielsvg arielsvg merged commit 57aa942 into develop Sep 2, 2020
@arielsvg arielsvg deleted the feature/improve-local-development-ux branch September 2, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants