-
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incremental loading for actions #449
Conversation
johnny243
commented
Aug 19, 2020
•
edited
Loading
edited
- actions are displayed as soon as they are resolved
- loading spinner is shown per extension
As mentioned in the SNJS PR, loading should be a client side concern. Easy solution would be to add a loadingState record in ActionsMenu: private readonly loadingState: Record<UuidString, Boolean> = {} And then use/modify that as needed. |
1954bc3
to
5062c1e
Compare
I've removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please upgrade SNJS and make sure type info is still correct
eb3ff5d
to
080d12c
Compare