Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incremental loading for actions #449

Merged
merged 8 commits into from
Aug 26, 2020
Merged

Conversation

johnny243
Copy link
Contributor

@johnny243 johnny243 commented Aug 19, 2020

  • actions are displayed as soon as they are resolved
  • loading spinner is shown per extension

@johnny243 johnny243 requested review from moughxyz and arielsvg August 19, 2020 19:27
@moughxyz
Copy link
Member

As mentioned in the SNJS PR, loading should be a client side concern. Easy solution would be to add a loadingState record in ActionsMenu:

private readonly loadingState: Record<UuidString, Boolean> = {}

And then use/modify that as needed.

@johnny243 johnny243 force-pushed the incremental-loading-actions branch from 1954bc3 to 5062c1e Compare August 25, 2020 04:43
@johnny243
Copy link
Contributor Author

I've removed the hidden property from the extension class: standardnotes/snjs#87

Copy link
Contributor

@arielsvg arielsvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upgrade SNJS and make sure type info is still correct

@johnny243 johnny243 requested a review from arielsvg August 25, 2020 17:02
@johnny243 johnny243 force-pushed the incremental-loading-actions branch from eb3ff5d to 080d12c Compare August 25, 2020 17:13
@johnny243 johnny243 merged commit c4506a5 into develop Aug 26, 2020
@johnny243 johnny243 deleted the incremental-loading-actions branch August 26, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants