Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add desktop repo #1071

Merged
merged 9 commits into from
Jun 7, 2022
Merged

feat: add desktop repo #1071

merged 9 commits into from
Jun 7, 2022

Conversation

moughxyz
Copy link
Member

@moughxyz moughxyz commented Jun 7, 2022

No description provided.

@moughxyz moughxyz requested a review from karolsojko June 7, 2022 14:28
response.setHeader('Cache-Control', 'max-age=604800')
response.setHeader('Content-Type', `${mimeType}; charset=utf-8`)

const data = fs.readFileSync(filePath)

Check failure

Code scanning / CodeQL

Potential file system race condition

The file may have changed since it [was checked](1).
packages/desktop/app/vendor/zip/z-worker.js Fixed Show fixed Hide fixed
packages/desktop/app/vendor/zip/deflate.js Fixed Show fixed Hide fixed
packages/desktop/app/vendor/zip/inflate.js Fixed Show fixed Hide fixed
packages/desktop/app/vendor/zip/inflate.js Fixed Show fixed Hide fixed
packages/desktop/app/vendor/zip/inflate.js Fixed Show fixed Hide fixed
packages/desktop/app/vendor/zip/inflate.js Fixed Show fixed Hide fixed

const mapping = this.getMappingFileFromDisk()

if (!mapping) {

Check warning

Code scanning / CodeQL

Missing await

Missing await. The value 'mapping' is always a promise.
packages/desktop/app/vendor/zip/zip.js Fixed Show fixed Hide fixed
@moughxyz moughxyz merged commit 0b7ce82 into develop Jun 7, 2022
@moughxyz moughxyz deleted the feat/desktop-repo branch June 7, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant