fix: running tests and adding tests to CI & CD #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanharwara
approved these changes
May 24, 2022
vardan-arm
approved these changes
May 24, 2022
Comment on lines
28
to
35
| coverageThreshold: { | ||
| global: { | ||
| branches: 3, | ||
| functions: 5, | ||
| lines: 21, | ||
| statements: 23, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
The positive numbers in "coverageThreshold" mean percentage, so maybe it makes more sense to increase these numbers (like to have branches coverage e.g. 60% instead of 3%)? Or the numbers are small in order to have the existing tests with low coverage passing right now?
https://jestjs.io/docs/configuration#coveragethreshold-object
There was a problem hiding this comment.
Yes, the intention here is to define the threshold in a way that does not allow it to get any lower. So this is the "current state" of coverage and we don't want it to get worse :)
added 2 commits
May 24, 2022 10:39
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.