Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: circular dependencies #1040

Merged
merged 1 commit into from
May 23, 2022
Merged

fix: circular dependencies #1040

merged 1 commit into from
May 23, 2022

Conversation

karolsojko
Copy link
Member

The tool is: https://www.npmjs.com/package/circular-dependency-plugin

Here's the output:

ERROR in Circular dependency detected:
app/assets/javascripts/Components/AccountMenu/AccountMenu.tsx -> app/assets/javascripts/Components/AccountMenu/GeneralAccountMenu.tsx -> app/assets/javascripts/Components/AccountMenu/AccountMenu.tsx

ERROR in Circular dependency detected:
app/assets/javascripts/Components/AccountMenu/ConfirmPassword.tsx -> app/assets/javascripts/Components/AccountMenu/AccountMenu.tsx -> app/assets/javascripts/Components/AccountMenu/ConfirmPassword.tsx

ERROR in Circular dependency detected:
app/assets/javascripts/Components/AccountMenu/CreateAccount.tsx -> app/assets/javascripts/Components/AccountMenu/AccountMenu.tsx -> app/assets/javascripts/Components/AccountMenu/CreateAccount.tsx

ERROR in Circular dependency detected:
app/assets/javascripts/Components/AccountMenu/GeneralAccountMenu.tsx -> app/assets/javascripts/Components/AccountMenu/AccountMenu.tsx -> app/assets/javascripts/Components/AccountMenu/GeneralAccountMenu.tsx

ERROR in Circular dependency detected:
app/assets/javascripts/Components/AccountMenu/SignIn.tsx -> app/assets/javascripts/Components/AccountMenu/AccountMenu.tsx -> app/assets/javascripts/Components/AccountMenu/SignIn.tsx

ERROR in Circular dependency detected:
app/assets/javascripts/Components/ChangeEditor/ChangeEditorButton.tsx -> app/assets/javascripts/Components/ChangeEditor/ChangeEditorMenu.tsx -> app/assets/javascripts/Components/NoteView/NoteView.tsx -> app/assets/javascripts/Components/ChangeEditor/ChangeEditorButton.tsx

ERROR in Circular dependency detected:
app/assets/javascripts/Components/ChangeEditor/ChangeEditorMenu.tsx -> app/assets/javascripts/Components/NoteView/NoteView.tsx -> app/assets/javascripts/Components/NotesOptions/NotesOptionsPanel.tsx -> app/assets/javascripts/Components/NotesOptions/NotesOptions.tsx -> app/assets/javascripts/Components/NotesOptions/ChangeEditorOption.tsx -> app/assets/javascripts/Components/ChangeEditor/ChangeEditorMenu.tsx

ERROR in Circular dependency detected:
app/assets/javascripts/Components/NoteView/NoteView.tsx -> app/assets/javascripts/Components/NotesOptions/NotesOptionsPanel.tsx -> app/assets/javascripts/Components/NotesOptions/NotesOptions.tsx -> app/assets/javascripts/Components/NotesOptions/ChangeEditorOption.tsx -> app/assets/javascripts/Components/ChangeEditor/ChangeEditorMenu.tsx -> app/assets/javascripts/Components/NoteView/NoteView.tsx

ERROR in Circular dependency detected:
app/assets/javascripts/Components/NotesOptions/ChangeEditorOption.tsx -> app/assets/javascripts/Components/ChangeEditor/ChangeEditorMenu.tsx -> app/assets/javascripts/Components/NoteView/NoteView.tsx -> app/assets/javascripts/Components/NotesOptions/NotesOptionsPanel.tsx -> app/assets/javascripts/Components/NotesOptions/NotesOptions.tsx -> app/assets/javascripts/Components/NotesOptions/ChangeEditorOption.tsx

ERROR in Circular dependency detected:
app/assets/javascripts/Components/NotesOptions/NotesOptions.tsx -> app/assets/javascripts/Components/NotesOptions/ChangeEditorOption.tsx -> app/assets/javascripts/Components/ChangeEditor/ChangeEditorMenu.tsx -> app/assets/javascripts/Components/NoteView/NoteView.tsx -> app/assets/javascripts/Components/NotesOptions/NotesOptionsPanel.tsx -> app/assets/javascripts/Components/NotesOptions/NotesOptions.tsx

ERROR in Circular dependency detected:
app/assets/javascripts/Components/NotesOptions/NotesOptionsPanel.tsx -> app/assets/javascripts/Components/NotesOptions/NotesOptions.tsx -> app/assets/javascripts/Components/NotesOptions/ChangeEditorOption.tsx -> app/assets/javascripts/Components/ChangeEditor/ChangeEditorMenu.tsx -> app/assets/javascripts/Components/NoteView/NoteView.tsx -> app/assets/javascripts/Components/NotesOptions/NotesOptionsPanel.tsx

ERROR in Circular dependency detected:
app/assets/javascripts/Components/PurchaseFlow/Panes/CreateAccount.tsx -> app/assets/javascripts/UIModels/AppState/PurchaseFlowState.ts -> app/assets/javascripts/Components/PurchaseFlow/PurchaseFlowWrapper.tsx -> app/assets/javascripts/Components/PurchaseFlow/PurchaseFlowView.tsx -> app/assets/javascripts/Components/PurchaseFlow/Panes/CreateAccount.tsx

ERROR in Circular dependency detected:
app/assets/javascripts/Components/PurchaseFlow/Panes/SignIn.tsx -> app/assets/javascripts/UIModels/AppState/PurchaseFlowState.ts -> app/assets/javascripts/Components/PurchaseFlow/PurchaseFlowWrapper.tsx -> app/assets/javascripts/Components/PurchaseFlow/PurchaseFlowView.tsx -> app/assets/javascripts/Components/PurchaseFlow/Panes/SignIn.tsx

ERROR in Circular dependency detected:
app/assets/javascripts/Components/PurchaseFlow/PurchaseFlowView.tsx -> app/assets/javascripts/UIModels/AppState/PurchaseFlowState.ts -> app/assets/javascripts/Components/PurchaseFlow/PurchaseFlowWrapper.tsx -> app/assets/javascripts/Components/PurchaseFlow/PurchaseFlowView.tsx

ERROR in Circular dependency detected:
app/assets/javascripts/Components/PurchaseFlow/PurchaseFlowWrapper.tsx -> app/assets/javascripts/Components/PurchaseFlow/PurchaseFlowView.tsx -> app/assets/javascripts/UIModels/AppState/PurchaseFlowState.ts -> app/assets/javascripts/Components/PurchaseFlow/PurchaseFlowWrapper.tsx

ERROR in Circular dependency detected:
app/assets/javascripts/UIModels/AppState/AppState.ts -> app/assets/javascripts/UIModels/AppState/ContentListViewState.ts -> app/assets/javascripts/UIModels/AppState/index.ts -> app/assets/javascripts/UIModels/AppState/AppState.ts

ERROR in Circular dependency detected:
app/assets/javascripts/UIModels/AppState/ContentListViewState.ts -> app/assets/javascripts/UIModels/AppState/index.ts -> app/assets/javascripts/UIModels/AppState/AppState.ts -> app/assets/javascripts/UIModels/AppState/ContentListViewState.ts

ERROR in Circular dependency detected:
app/assets/javascripts/UIModels/AppState/PurchaseFlowState.ts -> app/assets/javascripts/Components/PurchaseFlow/PurchaseFlowWrapper.tsx -> app/assets/javascripts/Components/PurchaseFlow/PurchaseFlowView.tsx -> app/assets/javascripts/UIModels/AppState/PurchaseFlowState.ts

ERROR in Circular dependency detected:
app/assets/javascripts/UIModels/AppState/index.ts -> app/assets/javascripts/UIModels/AppState/AppState.ts -> app/assets/javascripts/UIModels/AppState/ContentListViewState.ts -> app/assets/javascripts/UIModels/AppState/index.ts

webpack 5.72.0 compiled with 19 errors in 64955 ms

@karolsojko karolsojko merged commit 0e25885 into develop May 23, 2022
@karolsojko karolsojko deleted the fix_circular branch May 23, 2022 12:18
This was referenced Jun 13, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moughxyz moughxyz Awaiting requested review from moughxyz

@amanharwara amanharwara Awaiting requested review from amanharwara

@vardan-arm vardan-arm Awaiting requested review from vardan-arm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@karolsojko