Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generic items list #1035

Merged
merged 49 commits into from
May 22, 2022
Merged

feat: generic items list #1035

merged 49 commits into from
May 22, 2022

Conversation

amanharwara
Copy link
Member

amanharwara and others added 21 commits May 19, 2022 00:19
@amanharwara
feat: make notes list generic to display files
2008511
@amanharwara
fix: file context menu
88940b6
@amanharwara
chore: remove unnecessary console log
b943bc6
@amanharwara
feat: prepare for snjs#743
85360a1
@moughxyz
Merge branch 'develop' of github.com:standardnotes/web into feat/gene…
aa39321 
…ric-items-list
@moughxyz
fix: display options type compatibility
aca8086
@moughxyz
fix: make webDisplayOptions observable
582a8ee
@amanharwara
refactor: fix file names
2f85df4
@amanharwara
Merge branch 'feat/generic-items-list' of github.com:standardnotes/we…
a476b9f 
…b into feat/generic-items-list
@amanharwara
fix: file selection issues
79400f1
@moughxyz
chore: merge develop
fa1844e
@moughxyz
Merge branch 'feat/generic-items-list' of github.com:standardnotes/we…
e12af41 
…b into feat/generic-items-list
@amanharwara
Merge branch 'develop' of github.com:standardnotes/web into feat/gene…
e68fae2 
…ric-items-list
@amanharwara
feat: use single-click to preview file list item
bd3b1b6 
feat: don't preview when selecting multiple files
@moughxyz
feat(wip): theming improvements
dd267fb
@moughxyz
feat: extend color variables available to themes
102be38
@amanharwara
feat: use file icon for files smart view
f9ab039
@amanharwara
fix: file item authorization
7e40ed7
@amanharwara
fix: note/file list item hover
d1070b7
@amanharwara
Merge branch 'feat/generic-items-list' of github.com:standardnotes/we…
977a23f 
…b into feat/generic-items-list
@amanharwara
Revert "fix: file item authorization"
e2abe2f 
This reverts commit 7e40ed7.
@amanharwara amanharwara changed the title feat: Generic items list feat: generic items list May 21, 2022
amanharwara and others added 20 commits May 21, 2022 21:08
@amanharwara
feat: use generic protected access authorization
8c2b41f
@amanharwara
feat: expose getSelectedItems function in SelectedItemsState
0956c5f
@amanharwara
feat: use named return value
d22740f
@amanharwara
refactor: conditional improvements
794efd3
@amanharwara
feat: expose firstSelectedNote getter
fce1f5c
@amanharwara
feat: remove unnecessary reload calls
760e6b2
@amanharwara
fix: type errors
0bc0fde
@amanharwara
refactor: better control flow and props
fc76e2b
@amanharwara
refactor: remove unnecessary prop
d3e1a94
@amanharwara
refactor: get only required properties
5fed838
@amanharwara
refactor: move conditional to named const
0edb7dc
@amanharwara
feat: make getSelectedItems generic
fb66083
@amanharwara
feat: return didSelect after selecting item
4a76e84
@moughxyz
feat: support optional files navigation
a2c19ba
@amanharwara
fix: web display options
e0d4e09
@amanharwara
feat: add new utility class
6b26000
@amanharwara
refactor: pass whole item for params
a02c5c5
@amanharwara
refactor: use early returns
6bd94f5
@amanharwara
fix: hidden icon styling
8661188
@amanharwara
chore: bump deps
d92c20b
@amanharwara amanharwara merged commit 6401da2 into develop May 22, 2022
@amanharwara amanharwara deleted the feat/generic-items-list branch May 22, 2022 13:21
This was referenced Jun 13, 2022
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moughxyz moughxyz moughxyz approved these changes

@vardan-arm vardan-arm Awaiting requested review from vardan-arm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanharwara @moughxyz