From 88cc50e8b6a1f88a679857ad456a341ad344f185 Mon Sep 17 00:00:00 2001 From: Aman Harwara Date: Sat, 6 Nov 2021 19:29:03 +0530 Subject: [PATCH] fix: Fix icon colors to be more themeable (#724) --- app/assets/icons/ic-accessibility.svg | 5 +++-- app/assets/icons/ic-chevron-down.svg | 6 +++--- app/assets/icons/ic-help.svg | 5 +++-- app/assets/icons/ic-info.svg | 5 +++-- app/assets/icons/ic-keyboard.svg | 5 +++-- app/assets/icons/ic-listed.svg | 6 ++++-- app/assets/icons/ic-security.svg | 5 +++-- app/assets/icons/ic-settings.svg | 5 +++-- app/assets/icons/ic-star.svg | 5 +++-- app/assets/icons/ic-user.svg | 5 +++-- .../components/AccountMenu/GeneralAccountMenu.tsx | 4 ++-- app/assets/stylesheets/_preferences.scss | 2 +- 12 files changed, 34 insertions(+), 24 deletions(-) diff --git a/app/assets/icons/ic-accessibility.svg b/app/assets/icons/ic-accessibility.svg index ffb780043b5..7d913389a03 100644 --- a/app/assets/icons/ic-accessibility.svg +++ b/app/assets/icons/ic-accessibility.svg @@ -1,3 +1,4 @@ - - + + \ No newline at end of file diff --git a/app/assets/icons/ic-chevron-down.svg b/app/assets/icons/ic-chevron-down.svg index 1c89552e675..190774efbf0 100644 --- a/app/assets/icons/ic-chevron-down.svg +++ b/app/assets/icons/ic-chevron-down.svg @@ -1,4 +1,4 @@ - - - \ No newline at end of file + + \ No newline at end of file diff --git a/app/assets/icons/ic-help.svg b/app/assets/icons/ic-help.svg index eaed4c3f79f..dfec7f52a97 100644 --- a/app/assets/icons/ic-help.svg +++ b/app/assets/icons/ic-help.svg @@ -1,3 +1,4 @@ - - + + \ No newline at end of file diff --git a/app/assets/icons/ic-info.svg b/app/assets/icons/ic-info.svg index 14107de4034..5756776844c 100644 --- a/app/assets/icons/ic-info.svg +++ b/app/assets/icons/ic-info.svg @@ -1,3 +1,4 @@ - - + + \ No newline at end of file diff --git a/app/assets/icons/ic-keyboard.svg b/app/assets/icons/ic-keyboard.svg index 8068326fd52..3d37ab60a8a 100644 --- a/app/assets/icons/ic-keyboard.svg +++ b/app/assets/icons/ic-keyboard.svg @@ -1,3 +1,4 @@ - - + + \ No newline at end of file diff --git a/app/assets/icons/ic-listed.svg b/app/assets/icons/ic-listed.svg index 3bac23a5ab7..7179c323e2f 100644 --- a/app/assets/icons/ic-listed.svg +++ b/app/assets/icons/ic-listed.svg @@ -1,3 +1,5 @@ - - + + \ No newline at end of file diff --git a/app/assets/icons/ic-security.svg b/app/assets/icons/ic-security.svg index dfa4b37cc8c..06ab6033b8d 100644 --- a/app/assets/icons/ic-security.svg +++ b/app/assets/icons/ic-security.svg @@ -1,3 +1,4 @@ - - + + \ No newline at end of file diff --git a/app/assets/icons/ic-settings.svg b/app/assets/icons/ic-settings.svg index 2191bea9a9d..2d2a2652865 100644 --- a/app/assets/icons/ic-settings.svg +++ b/app/assets/icons/ic-settings.svg @@ -1,3 +1,4 @@ - - + + \ No newline at end of file diff --git a/app/assets/icons/ic-star.svg b/app/assets/icons/ic-star.svg index f74b0d56760..19072b969b1 100644 --- a/app/assets/icons/ic-star.svg +++ b/app/assets/icons/ic-star.svg @@ -1,3 +1,4 @@ - - + + \ No newline at end of file diff --git a/app/assets/icons/ic-user.svg b/app/assets/icons/ic-user.svg index 1bdfaf61f28..ee303b0eeca 100644 --- a/app/assets/icons/ic-user.svg +++ b/app/assets/icons/ic-user.svg @@ -1,3 +1,4 @@ - - + + \ No newline at end of file diff --git a/app/assets/javascripts/components/AccountMenu/GeneralAccountMenu.tsx b/app/assets/javascripts/components/AccountMenu/GeneralAccountMenu.tsx index f2f6d017100..88fd1c71846 100644 --- a/app/assets/javascripts/components/AccountMenu/GeneralAccountMenu.tsx +++ b/app/assets/javascripts/components/AccountMenu/GeneralAccountMenu.tsx @@ -19,7 +19,7 @@ type Props = { closeMenu: () => void; }; -const iconClassName = 'color-grey-1 mr-2'; +const iconClassName = 'color-neutral mr-2'; export const GeneralAccountMenu: FunctionComponent = observer( ({ application, appState, setMenuPane, closeMenu }) => { @@ -60,7 +60,7 @@ export const GeneralAccountMenu: FunctionComponent = observer(
Account
- +
{user ? ( diff --git a/app/assets/stylesheets/_preferences.scss b/app/assets/stylesheets/_preferences.scss index adea056059f..5337a5d1900 100644 --- a/app/assets/stylesheets/_preferences.scss +++ b/app/assets/stylesheets/_preferences.scss @@ -21,7 +21,7 @@ @extend .border-1; .icon { - color: var(--sn-stylekit-grey-1); + color: var(--sn-stylekit-neutral-color); @extend .text-base; }