Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sphinx LInks with Correct V2 pubkey encoding to add people form registry #635

Closed
Tracked by #628 ...
humansinstitute opened this issue Nov 12, 2024 · 3 comments · Fixed by #640
Closed
Tracked by #628 ...
Assignees
Labels
Bounties bug Something isn't working

Comments

@humansinstitute
Copy link
Collaborator

humansinstitute commented Nov 12, 2024

Correct the encoding to V2 pubkeys in the boutnies front end.

  • Select user with Pub Key V2 e.g. "Pete"
  • Click through on QR code for connection details

image

  1. Clicking open in sphinx will correctly open the user in sphinx app -> works correctly
  2. Scan QR with Phone -> works correctly
  3. Copy and pasting the pebkey and adding via sphinx -> doesn't work
  4. Copy and pasting the pubkey into a chat in sphinx -> generates a connect button -> clicking this doesn't work

This is due to the data in the pub key being displayed for copying being incorrect formated.

- V1 Pubkey (General) ->    <part1>:<part2>:<part3>     // Filter Out [V1 format - will be removed]
- V2 Pubkey (Bounties) ->  <part1>:<part2>_<part3>    // This is how the Pubkey is displayed 
- V2 Pubkey (Sphinx) ->     <part1>_<part2>_<part3>   // Allow [correct V2 format]

We need to ensure that the correct encoding is used in displaying and copying of this pubkey.

let part1 = <part1>
let part2 = <part2>
let part13 = <part3>
pubkey = `${part1}_${part2}_${part3}`
@humansinstitute
Copy link
Collaborator Author

@saithsab877 - follow up task to stakwork/sphinx-tribes#1944

@saithsab877
Copy link
Contributor

@humansinstitute Please assign me

@saithsab877
Copy link
Contributor

@saithsab877 - follow up task to stakwork/sphinx-tribes#1944

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounties bug Something isn't working
Projects
None yet
2 participants