-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GRD: Consider using footprint from productInfo.json instead of safe:footPrint from SAFE manifest #56
Comments
@lossyrob do you have any insight as to why the bbox-like footprint from the manifest was using instead of the geojson footprint from productInfo.json? |
When I did https://github.com/sat-utils/sat-stac-sentinel/blob/master/stac_sentinel/sentinel.py it used the productInfo.json file and the footprint still had an issue of being not very accurate. Then, sat-stac-sentinel spawned stac-sentinel where a lot of the stactools-sentinel1 logic was derived from. But that: https://github.com/stac-utils/stac-sentinel/blob/main/stac_sentinel/sentinel.py#L93 looks like it is only for the Sentinel-1 RTC dataset on AWS which is tiled. So I'm definitely +1 to use productInfo, but also interested in more info about the differences between them. Do you find that the productInfo footprint is accurate @philvarner ? |
@philvarner I don't have insights, but have seen instances of GRD footprints being off. If productInfo has a better footprint then I'd agree we should change to use them. |
The existing package footprint is clearly the worse. Planetary Computer's footprint is the same as productInfo.json but with fewer decimal places, and Earth Search's recomputation from the raster is tighter, but not by much. |
Is your feature request related to a problem? Please describe.
Currently, GRD uses the footprint element in the SAFE manifest (effectively a bbox) to produce a polygon.
e.g.,
This is not a very accurate footprint for the scene, and has at least one bug with it (#55),
Instead, consider using the productInfo.json "footprint" attribute. This has a MultiPolygon for antimeridian-spanning scenes and more accurate geometries of all scenes.
The text was updated successfully, but these errors were encountered: