Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nakamoto Signer[3.0] - Update Block Header to use a vec of Signatures #4776

Closed
saralab opened this issue May 10, 2024 · 1 comment · Fixed by #4781
Closed

Nakamoto Signer[3.0] - Update Block Header to use a vec of Signatures #4776

saralab opened this issue May 10, 2024 · 1 comment · Fixed by #4781
Assignees
@hstove
Labels
3.0-must 3.0-Signer 3.0 locked
Milestone
Nakamoto Mileston...

Comments

@saralab
Copy link
Contributor

saralab commented May 10, 2024

stackslib: chainstate::nakamoto

The NakamotoBlockHeader struct will need to be updated to include a vec of signatures rather than an aggregated signature.

The block validation paths (append_block) and (accept_block) will need to be updated with the new signature validation logic.
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng May 10, 2024
@saralab saralab moved this from Status: 🆕 New to Status: 📋 Backlog in Stacks Core Eng May 10, 2024
@hstove hstove mentioned this issue May 13, 2024
Merged
5 tasks
@saralab saralab moved this from Status: 📋 Backlog to Status: In Review in Stacks Core Eng May 16, 2024
@hstove hstove linked a pull request May 31, 2024 that will close this issue
modify nakamoto block header to use Vec<MessageSignature> #4781
Merged
5 tasks
@saralab saralab closed this as completed Jun 5, 2024
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: ✅ Done in Stacks Core Eng Jun 5, 2024
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hstove hstove

Labels
3.0-must 3.0-Signer 3.0 locked
Projects
Stacks Core Eng
Archived in project
Milestone
Nakamoto Milestone 0.4 [3.0 Activation]
Development

Successfully merging a pull request may close this issue.

modify nakamoto block header to use Vec<MessageSignature> stacks-network/stacks-core
3 participants
@saralab @hstove @blockstack-devops