Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to k8s #44

Merged
merged 13 commits into from
Jul 3, 2023
Merged

Deploy to k8s #44

merged 13 commits into from
Jul 3, 2023

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jun 15, 2023

Description

Fixes #18

This PR migrates the JS build from pnpm to yarn, since pnpm2nix is pretty bitrotted, and neither dream2nix nor js2nix support pnpm.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr requested a review from Techassi June 15, 2023 14:31
@nightkr nightkr marked this pull request as ready for review June 20, 2023 10:39
@nightkr nightkr requested a review from a team June 30, 2023 09:55
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
deploy/helm/stackable-cockpit/README.md Outdated Show resolved Hide resolved
web/build.rs Show resolved Hide resolved
web/build.rs Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but as already discussed, the build/deploy toolchain seems very convoluted. This discussion is, however, better placed in an arch meeting.

@nightkr nightkr enabled auto-merge July 3, 2023 09:35
@nightkr nightkr added this pull request to the merge queue Jul 3, 2023
Merged via the queue into main with commit 12c957b Jul 3, 2023
@nightkr nightkr deleted the feature/k8s-deploy branch July 3, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes/tilt manifests and container images
2 participants