Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite listener volume docs #512

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Rewrite listener volume docs #512

merged 3 commits into from
Oct 28, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Oct 24, 2024

Description

Fixes #496 (hopefully).

Also moves the listener volume scope to the top of the list and adds caveats to the other scopes.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

No tasks being tracked yet.

Reviewer

Acceptance

Fixes #496 (hopefully).

Also moves the listener volume scope to the top of the list and adds caveats to the other scopes.
@nightkr nightkr requested review from razvan and a team October 24, 2024 14:28
@nightkr
Copy link
Member Author

nightkr commented Oct 24, 2024

Particularly curious to hear @razvan's thoughts, though I think it's still a bit more abstract than would be ideal...

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nightkr nightkr added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 1706687 Oct 28, 2024
31 checks passed
@nightkr nightkr deleted the docs/listener-volume-rewrite branch October 28, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify documentation for the listener volume scope
3 participants