Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stackable-versioned): Generate Kubernetes code independent of container order #913

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Nov 27, 2024

Part of stackabletech/issues#642, follow-up of #912

This fixes the wrong generation of Kubernetes specific code which could be triggered by either

  • versioning enums alongside structs in a module or
  • versioning containers with and without the k8s argument in mixed order

@Techassi Techassi self-assigned this Nov 27, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 3e5b3ba Nov 27, 2024
10 checks passed
@Techassi Techassi deleted the fix/stackable-versioned-kubernetes-code-for-containers branch November 27, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Development: Done
Development

Successfully merging this pull request may close these issues.

2 participants