Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade jsonschema=4.19 #1214

Closed
emmaai opened this issue Sep 7, 2023 · 2 comments
Closed

Upgrade jsonschema=4.19 #1214

emmaai opened this issue Sep 7, 2023 · 2 comments

Comments

@emmaai
Copy link

emmaai commented Sep 7, 2023

As the title, the reason is that the new version of Jupyter lab depends on >=4.18
@emmaai emmaai changed the title any change to upgrade jsonschema=4.19 any chance to upgrade jsonschema=4.19 Sep 7, 2023
@vincentsarago
Copy link
Member

This is blocked by #1186

As mentioned in

pystac/pyproject.toml

Lines 67 to 68 in 9835823

# jsonschema v4.18.2 breaks validation, and it feels safer to set a ceiling rather than just skip this version. The ceiling should be removed when the v4.18 lineage has settled down and feels safer.
validation = ["jsonschema>=4.0.1,<4.18"]

Any PR is more than welcome 🙏

@gadomski gadomski changed the title any chance to upgrade jsonschema=4.19 Upgrade jsonschema=4.19 Sep 7, 2023
@2320sharon 2320sharon mentioned this issue Sep 7, 2023
Closed
This was referenced Sep 8, 2023
Merged
Merged
@gadomski
Copy link
Member

Done by #1186: https://github.com/stac-utils/pystac/actions/runs/6240132061/job/16939541649#step:4:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gadomski @emmaai @vincentsarago