Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default CatalogType to RELATIVE_PUBLISHED #1113

Open
gadomski opened this issue May 4, 2023 · 0 comments
Open

Change default CatalogType to RELATIVE_PUBLISHED #1113

gadomski opened this issue May 4, 2023 · 0 comments
Labels
Milestone

Comments

@gadomski
Copy link
Member

gadomski commented May 4, 2023

We end up with a lot of folks expecting relative hrefs instead of absolute:

I'm proposing to change our default catalog type

catalog_type: CatalogType = CatalogType.ABSOLUTE_PUBLISHED,
to RELATIVE_PUBLISHED, which will likely fix both of these issues

I think this would be considered a breaking change, as folks might be expecting absolute behavior by default? Because of that, I'm not opening a PR to do it, but rather opening this issue to build consensus on whether (a) we should do this and (b) if this should be part of a MAJOR release (instead of a MINOR).

@gadomski gadomski added this to the v2.0 milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant