Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contradiction in specification definition - raster vs. vector #12

Open
KennSmithDS opened this issue Sep 14, 2022 · 2 comments
Open

Contradiction in specification definition - raster vs. vector #12

KennSmithDS opened this issue Sep 14, 2022 · 2 comments

Comments

@KennSmithDS
Copy link

KennSmithDS commented Sep 14, 2022

Background:

At Radiant Earth, we've been using the label extension for both raster and vector label assets in our catalogs/datasets. This means that any item which represents a label asset from an ML dataset will employ the label extension. These labels will most commonly be either GeoJSON or GeoTIFF, with some exceptions of Numpy array files, etc. However, reading closer into the specification today, I noticed a contradiction.

Issue

In the first section of the specification, there is the verbiage:
These labels can take several forms, though all are expected to be contained with a GeoJSON FeatureCollection - emphasis on expected to be contained with a GeoJSON FeatureCollection

Yet then, the label:type field stores an ENUM of either raster or vector.

If the former is true, that label assets must be contained within a GeoJSON, then raster images with classification labels do not apply to this extension.

Proposal/request

  1. Revise the specification to remove the contradiction, in one place stating labels are expected to be GeoJSON only, while in another place stating it can be GeoJSON (vector) or GeoTIFF (raster). Also vector value for label:type could also imply other vector file formats, e.g. shapefile, not just GeoJSON.
  2. Add explanation for how to handle raster label data. Should these be a combination of raster & classification extensions? Should the label extension still be applied to an item with raster label assets?
@KennSmithDS
Copy link
Author

KennSmithDS commented Sep 14, 2022

Furthermore, clarification would be helpful on the implementation of the name property of the ClassObject, which currently states:

REQUIRED The property key within the asset's each Feature corresponding to class labels. If labels are raster-formatted, use null.

If the label extension is intended to be used with vector assets only, then for raster assets with contain labels, shouldn't the line "If labels are raster-formatted, use null" be removed from the specification, and the classification:classes property take precedence over label:classes?

@KennSmithDS
Copy link
Author

Pending @kbgg review on #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant