Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Flashcard review order "random card from random deck" - make info in modal title useful #851

Open
ronzulu opened this issue Jan 21, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ronzulu
Copy link
Collaborator

ronzulu commented Jan 21, 2024

Describe the bug
From comment by @4Source #814 (comment).

The title information for the flashcard review modal has the format:
${deckName}: ${cardCount}

With:
${deckName} - The name of the deck of the currently shown card
${cardCount} - The count of cards remaining to be reviewed in this deck.

This is useful info for all review order modes, except for "random card from random deck".

Expected behavior
In this mode it is more useful to display:

selectedDeckName - the name of the deck chosen by the user (doesn't change as cards from different subdecks are shown)
descendantDeckCount - count of descendant decks under the deck chosen by the user. This being the remaining count, i.e. the count of descendant decks that have 1 or more remaining cards for review
totalCardCount - total number of cards remaining for review across the chosen deck and all descendant decks (I.e. not the count of cards remaining in the current randomly chosen deck).
currentDeckName - The name of the deck of the currently shown card (needed for context)
cardCount - The count of cards remaining to be reviewed in this current deck. This is what is currently shown, and personally I don't find it very useful. Don't mind if it's present though.

@ronzulu ronzulu added the bug Something isn't working label Jan 21, 2024
@4Source
Copy link
Contributor

4Source commented Jan 21, 2024

What do you think about a Format
Title: ${deckName}: ${cardCount}
Subtitle: Subdecks: ${subdeckCount} | ${subdeckName}: ${subdeckCardCount}

deckName - the name of the deck chosen by the user (doesn't change as cards from different subdecks are shown)
cardCount - the total number of all cards in subdecks chosen by the user
subdeckCount - the number of all subdecks with remaining cards to review
subdeckName - the name of the subdeck from which the current reviewed card is
subdeckCardCount - the number of remaining cards of the subdeck from which the current reviewed card is

@4Source
Copy link
Contributor

4Source commented Jan 21, 2024

Something like that
image

When the lowest level of a deck is the selected one subdeckName and deckName would be the same that maybe a downside. This could be solved when only add the Subtitle if an Subdeck exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants