Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action buttons fixed on top of the card back content #46

Closed
rvenugopal opened this issue May 4, 2021 · 8 comments
Closed

Action buttons fixed on top of the card back content #46

rvenugopal opened this issue May 4, 2021 · 8 comments
Labels
bug Something isn't working

Comments

@rvenugopal
Copy link

rvenugopal commented May 4, 2021

Hello

Thanks for making this plugin. An issue I am encountering is the buttons are hovering over the card back content instead of being fixed at the bottom. Please see screenshot below.

Obsidian app version: 0.11.13
Obsidian spaced repetition version: 1.4.2

How I am creating the card:
The way I am making this card is using the multiline syntax (as described in the wiki) except I am using the code block as the back portion of the card. If I knew how to look at the HTML structure I could debug this and offer a CSS fix. However, I am not sure how to view the HTML in an electron app.

Potential solution:
One solution is to make the flashcardView as flex with column direction and overflow auto. Then you can have a header / top section and a footer section with the buttons. The middle div (flashcardContent ) can be sent to the markdown renderer with flex grow 1 and that would expand automatically.

flashcardView.style = {
   display: flex;
   flex-directon: column;
   overflow: auto;
   flex-grow: 0 1 0;
}

The html can be

<div id="flashcardview">
   <div></div>
   <div id="flashcardContent"></div>
   <div id="buttons"></div>
</div>

Current issue:
Screen Shot 2021-05-04 at 3 15 33 PM

@rvenugopal rvenugopal changed the title Response Action buttons fixed on top of the card back content May 5, 2021
@st3v3nmw st3v3nmw added the bug Something isn't working label May 5, 2021
@st3v3nmw
Copy link
Owner

st3v3nmw commented May 5, 2021

Hello,

I'll work on fixing this.
Thanks for the bug report & the potential solution.

@rvenugopal
Copy link
Author

👍🏽

@st3v3nmw
Copy link
Owner

st3v3nmw commented May 8, 2021

I added an option to make the flashcards view scrollable in the latest release (v1.4.3). Please check it out.

@rvenugopal
Copy link
Author

@st3v3nmw Thanks for working on this. I just installed v1.4.4 and the modal does not even open up when I try to review

@st3v3nmw
Copy link
Owner

st3v3nmw commented May 8, 2021

What Obsidian version do you have?

@st3v3nmw
Copy link
Owner

st3v3nmw commented May 8, 2021

There's an API I'm using that's only available on Obsidian v0.12.2, I thought the versions.json file would allow older Obsidian versions to install v1.4.3.
I'll roll back to v1.4.3 for now.

Turns out I hadn't added the minimum app version correctly, should be fixed now.

@rvenugopal
Copy link
Author

rvenugopal commented May 8, 2021

Confirming that v1.4.3 works as expected. Thanks for resolving this. Should I close this issue?
👍🏽

@st3v3nmw
Copy link
Owner

Thanks for the confirmation. I'll just close this issue on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants