Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Inline flashcard separator conflicts with inline codeblocks #382

Open
rdimaio opened this issue Jan 25, 2022 · 0 comments
Open

[BUG] Inline flashcard separator conflicts with inline codeblocks #382

rdimaio opened this issue Jan 25, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@rdimaio
Copy link

rdimaio commented Jan 25, 2022

Describe the bug
Hey, first off I'd like to thank you and everyone who contributed to this plugin, it's exactly what I was looking for 😄

I'm facing a similar issue to #76:

I'm using the default :: inline flashcard separator, and I have this inline code (single backticks) in my notes: `typedef std::vector int_vec_t;` which is incorrectly detected by the plugin as a single-line flashcard:
image

This problem doesn't occur when I have the code in a multi-line block (triple backticks), like this:
```
typedef std::vector int_vec_t;
```

I had a look at PR #98 and at the current codebase, and I'm not sure where the codeblock parsing is done within the code.

To Reproduce
Steps to reproduce the behavior:

  1. Place an inline flashcard separator within an inline code block

Expected behavior
The plugin should probably ignore flashcard separators that are within inline code blocks, like it's being done with multi-line code blocks

Versions (please complete the following information):

  • OS: Windows 10
  • Obsidian version: v0.13.19
  • Plugin version: v1.7.1
  • If on desktop, Installer version: "5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) obsidian/0.13.14 Chrome/91.0.4472.164 Electron/13.6.2 Safari/537.36"
@rdimaio rdimaio added the bug Something isn't working label Jan 25, 2022
@github-actions github-actions bot added the stale label Apr 9, 2023
@st3v3nmw st3v3nmw removed the stale label May 13, 2023
@ronzulu ronzulu self-assigned this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants