Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Stopped working on iPhone and iPad after 1.12.5 #1037

Closed
Ti-mmm opened this issue Aug 4, 2024 · 10 comments · Fixed by #1048
Closed

[Bug]: Stopped working on iPhone and iPad after 1.12.5 #1037

Ti-mmm opened this issue Aug 4, 2024 · 10 comments · Fixed by #1048
Labels
bug Something isn't working

Comments

@Ti-mmm
Copy link

Ti-mmm commented Aug 4, 2024

Describe the bug

I am unable to use the plugin after updating to the newest version on my iPhone and iPad. The plugin works fine on PC. Even with all other plugins disabled and the default theme, it still doesn‘t work.

To Reproduce

  1. Be on iOS/iPadOS 16.7 (not sure if needed)
  2. Update the plugin to newest version
  3. try to open "Review Flashcards"
  4. menu does not open

Expected behavior

After doing command „Spaced Repetition: Review flashcards from all Notes“ the menu should open, which it does not.

Screenshots

No response

OS of your device

iOS 17.6 / iPadOS 17.6

Obsidian version

1.6.7

Plugin version

1.12.5

Installer version

No response

Additional context

No response

Config file

No response

@Ti-mmm Ti-mmm added the bug Something isn't working label Aug 4, 2024
@Ti-mmm Ti-mmm changed the title Stopped working on iPhone and iPad after 1.12.5 [BUG]: Stopped working on iPhone and iPad after 1.12.5 Aug 4, 2024
@Ti-mmm Ti-mmm changed the title [BUG]: Stopped working on iPhone and iPad after 1.12.5 [Bug]: Stopped working on iPhone and iPad after 1.12.5 Aug 4, 2024
@ronzulu
Copy link
Collaborator

ronzulu commented Aug 5, 2024

Curious, were you using the same vault on the PC as on the iPhone/iPad?

@Ti-mmm
Copy link
Author

Ti-mmm commented Aug 5, 2024

Yes - I have Obsidian Sync enabled.
Also, I've just tried out the plugin on a fresh vault in iOS and it seems to work perfectly on there.

@iliankai
Copy link

iliankai commented Aug 5, 2024

You are not alone. I'm having the same issue with iOS 17.6 / iPadOS 17.6. The vault is synchronized in iCloud.
I tried to uninstall and then to install the plugin. Didn't work.

@ronzulu
Copy link
Collaborator

ronzulu commented Aug 6, 2024

Thanks for the info. Interesting that the same vault works on the PC, and a fresh vault works on the mobile. This seems to imply that there is something within the vault that triggers specific code that isn't working in the mobile environment.

If you could please try out the beta 12 release, as per #1033 (comment)

Cheers
Ronny

@Ti-mmm
Copy link
Author

Ti-mmm commented Aug 6, 2024

Hello again. I seem to have found a solution. The issue seems to be the data.json, and the setting causing the crash is "noteFoldersToIgnore", which I had set to "noteFoldersToIgnore": [ "Personal" ],. Changing it to "noteFoldersToIgnore": [], which should be the default setting fixed the issue and let me use the plugin again on my phone.
Also, not sure if this is still needed info but I did try changing to the beta 12 release as well as 1.12.4 and that did not solve the issue.

@Ti-mmm
Copy link
Author

Ti-mmm commented Aug 6, 2024

Here's the log error too:
Unhandled promise rejection: TypeError: undefined is not an object (evaluating 'this.baseDeckTree.getDeck')

@ronzulu
Copy link
Collaborator

ronzulu commented Aug 7, 2024

Thanks for that, and that is largely consistent with #1033.

The reason why your workaround worked is that if noteFoldersToIgnore is empty, then there is no attempt to call the (missing on mobile) system API normalize.

@iliankai
Copy link

iliankai commented Aug 7, 2024

IMG_1774
Thanks for the workaround, @Ti-mmm .
I removed all the words in "Folders to ignore ", then "Review Flashcards" could bring out the menu.

@TfTHacker
Copy link
Contributor

I have been using this plugin daily for a few years, and I can confirm it stopped working some time back. Today I removed the exclusion folders and it started to work again.

I am on iPhone. I am just happy it is working again, the folder exclusion is not such a big deal, but of course it would be nice to have it working.

@ronzulu ronzulu linked a pull request Sep 2, 2024 that will close this issue
@ronzulu
Copy link
Collaborator

ronzulu commented Sep 2, 2024

Hi this has been fixed in #1048, but not yet released.

@Ti-mmm Ti-mmm closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants