You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I forked your repository for using at my company and I was requested to make some adaptations on it before using, and while on it the linter complained about one problem that actually seems important on the following lines of code:
Here the code checks whether the metadata is present or not, but if it is undefined it will just continue running. And I don't think this is likely to work because we even make function calls on the subattributes like in:
Hello, good morning.
I forked your repository for using at my company and I was requested to make some adaptations on it before using, and while on it the linter complained about one problem that actually seems important on the following lines of code:
https://github.com/ssut/nestjs-sqs/blob/master/lib/sqs.service.ts#L39-L53
Here the code checks whether the metadata is present or not, but if it is undefined it will just continue running. And I don't think this is likely to work because we even make function calls on the subattributes like in:
so even if I replaced all
.
with.?
it would still break on that line.I was wondering whether we might need to skip the iteration if we detect that the metadata is nil instead of just logging a warning.
The text was updated successfully, but these errors were encountered: