Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomResourceHandler lambda runtime is not updating to nodejs20 #19

Open
dignat opened this issue Dec 10, 2024 · 2 comments
Open

CustomResourceHandler lambda runtime is not updating to nodejs20 #19

dignat opened this issue Dec 10, 2024 · 2 comments

Comments

@dignat
Copy link

dignat commented Dec 10, 2024


Hey everyone, we started to plan upgrade to nodejs20 - our custom lambdas and logRetention lambdas are successfully upgraded after upgrade to sst v2.45.0 and aws-cdk-lib: v2.171.1. But the CustomResourceHandlers are still showing runtime nodejs18. Coudl you please look into this and let me know how we can overcome this issue.

The problem could be here :
image001(1)

here the live.lambda runtime is nodejs18: https://github.com/sst/v2/blob/master/packages/sst/src/constructs/Function.ts#L977
and here could be the reason of our issue: https://github.com/sst/v2/blob/master/packages/sst/src/constructs/Function.ts#L1031

@dignat dignat closed this as completed Dec 10, 2024
@dignat dignat reopened this Dec 10, 2024
@jayair
Copy link
Contributor

jayair commented Dec 14, 2024

Happy to take a PR for this.

@dignat
Copy link
Author

dignat commented Dec 18, 2024

Hey @jayair, @fwang please take a look at this proposed Spec and let me know your thoughts. There are bunch of files that are involved in Custom resource creation and most of the runtime is hard coded to NODEJS_18_X.
Spec for Updating runtime for Custom resources:

  1. Update runtime to NodeJS_20_X in packages/sst/src/constructs Function.ts
  2. Update runtime to NodeJS_20_X in packages/sst/src/constructs Function.test.ts
  3. Update runtime to NodeJS_20_X in packages/sst/src bootrstrap.ts
  4. Update runtime to NodeJS_20_X in packages/sst/src/constructs EdgeFunction.ts
  5. Update runtime to NodeJS_20_X in packages/sst/src/constructs EventBus.ts
  6. Update runtime to NodeJS_20_X in packages/sst/src/constructs Jobs.ts
  7. Update runtime to NodeJS_20_X in packages/sst/src/constructs RDS.ts
  8. Update runtime to NodeJS_20_X in packages/sst/src/constructs Script.ts
  9. Update runtime to NodeJS_20_X in packages/sst/src/constructs Stack.ts
  10. Update runtime to NodeJS_20_X in packages/sst/src/constructs/cdk dns-validate-certificate.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants