Skip to content
This repository has been archived by the owner on Oct 27, 2024. It is now read-only.

SetInterfaceDnsSettings was not supported by older version of Windows #84

Closed
zonyitoo opened this issue Jul 13, 2024 · 4 comments · Fixed by #85
Closed

SetInterfaceDnsSettings was not supported by older version of Windows #84

zonyitoo opened this issue Jul 13, 2024 · 4 comments · Fixed by #85

Comments

@zonyitoo
Copy link

ref shadowsocks/shadowsocks-rust#1589

The procedure entry point SetInterfaceDnsSettings could not be located in the dynamic link library C:\Users\Administrator\Desktop\shadowsocks-rust-master\target\release\full\sslocal.exe.

It was introduced from https://github.com/tun2proxy/rust-tun/pull/74/files .

@zonyitoo
Copy link
Author

This is a special feature provided by crate wintun: https://github.com/nulldotblack/wintun/blob/590481325c91debdd52afc2383d07ec9f5bc1523/src/util.rs#L88-L102 .

wintun.dll supports Windows 7, 8, 10, 11: https://git.zx2c4.com/wintun/about/ .

@ssrlive
Copy link
Owner

ssrlive commented Jul 13, 2024

You are right. but it's hard to commit patch to wintun crate, similar to tun crate.

https://learn.microsoft.com/en-us/windows/win32/api/netioapi/nf-netioapi-setinterfacednssettings#requirements

@zonyitoo
Copy link
Author

Would you consider making set_dns_servers behind a feature gate? For example, adding a feature = "dns_servers".

@ssrlive
Copy link
Owner

ssrlive commented Jul 13, 2024

PR welcome, I will merge it in first time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants