-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marking which controllers are active on which vials #208
Comments
I presume the UI part of this is blocked/needs some kind of controllers/experiments api. |
I think the controllers config should support a vial list so In reality - to be precise - it might be more nuanced than that since it could be a controller that only sends control commands to a hardware which itself is active on only certain vials, but we might simply start with the vials config. |
Yeah i think the best place for that is on the backend. e.g. get This lets us in the backend encode whatever rules may exist for a controller applying to all vials, or a particular vial, or a sub-set of vials. Currently as you say, simply "just look at what vials a controller refs in its config", later ... whatever else... IMO this is preferable to the front end doing this ad-hoc basis, e.g. the answer to the question "does a controller with no vials in its config apply to all vials, no vials, some vials subject to some intermediate condition?" should be encoded in the backend as it is an assumption that exists across the system. |
Makes sense, we can add a getter to the manager and corresponding web api as you suggest. It might be nice as well having a get |
made #233 |
No description provided.
The text was updated successfully, but these errors were encountered: