Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking which controllers are active on which vials #208

Open
Tracked by #182
amitschang opened this issue Nov 13, 2024 · 5 comments
Open
Tracked by #182

Marking which controllers are active on which vials #208

amitschang opened this issue Nov 13, 2024 · 5 comments
Labels
enhancement New feature or request new feature UI

Comments

@amitschang
Copy link
Member

No description provided.

@amitschang amitschang mentioned this issue Nov 13, 2024
11 tasks
@amitschang amitschang added enhancement New feature or request new feature UI labels Nov 13, 2024
@imaitland
Copy link
Collaborator

I presume the UI part of this is blocked/needs some kind of controllers/experiments api.

@amitschang
Copy link
Member Author

I presume the UI part of this is blocked/needs some kind of controllers/experiments api.

I think the controllers config should support a vial list so Controller.Config.vials could be inspected to see which vials it ought to be active on (or absent would be all of them)

In reality - to be precise - it might be more nuanced than that since it could be a controller that only sends control commands to a hardware which itself is active on only certain vials, but we might simply start with the vials config.

@imaitland
Copy link
Collaborator

Yeah i think the best place for that is on the backend.

e.g.

get /controllers endpoint accepts a vials query param and returns an object, indexed by vial with the active controllers on that vial...or similar.

This lets us in the backend encode whatever rules may exist for a controller applying to all vials, or a particular vial, or a sub-set of vials.

Currently as you say, simply "just look at what vials a controller refs in its config", later ... whatever else...

IMO this is preferable to the front end doing this ad-hoc basis, e.g. the answer to the question "does a controller with no vials in its config apply to all vials, no vials, some vials subject to some intermediate condition?" should be encoded in the backend as it is an assumption that exists across the system.

@amitschang
Copy link
Member Author

Makes sense, we can add a getter to the manager and corresponding web api as you suggest. It might be nice as well having a get /controller/{controller} that returns the controller config plus recent logs in one call, for when drilling down into the list returned by /controllers.

@amitschang
Copy link
Member Author

made #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature UI
Projects
None yet
Development

No branches or pull requests

2 participants