Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Want to join the main development team? #45

Closed
engelgabriel opened this issue Aug 7, 2015 · 10 comments
Closed

Want to join the main development team? #45

engelgabriel opened this issue Aug 7, 2015 · 10 comments

Comments

@engelgabriel
Copy link

We guys seem very active and developing some very important features we have been missing on the Rocket.Chat main project. We'd love to have you guys on the team, or at least help you push more PRs to the main project to keep them more in sync :)

@bbrockman
Copy link

It would be great to work together. If they are shared features, we'd love to push them your way. One of our big new features will be a contact list pulled from ldap. Have you guys thought much about that? We're deciding now where the best place to put it would be. Hard to decide since there is already flex panels on the right and left. Please feel free to comment on any features we have. We would appreciate your opinions. We hope to create docker containers for development for ldap and meteor.

@engelgabriel
Copy link
Author

Cool, thats one of the most wanted features in our Roadmap. We have a Federal University in Brazil that wants to deploy the chat for 40k students.. and they need to load the users form their LDAP server.

Lets work on this together!!!

We should add this to the LDAP package. It already does the authentication using ldap domain.

Is there a webhook on your ldap server to push changes? Or should the chat server pool periodically for changes and diff? In that case, is there a update timestamp to narrow the query?

@engelgabriel
Copy link
Author

I'll ask the other contributors to do a pull request from your branch and see what can we merge back to our master. We can all work together to resolve conflicts and get the source code synced again. Our idea is that you should be able to add ANY feature using the packages APIs.

So in the ideal scenario, your fork would be EXACTLY like our master, and you'd have some extra folders inside /packages/ with your EXTRA features.

If you join the core development team, you can help us create the APIs that are missing to allow you to do that.

@engelgabriel
Copy link
Author

The original issue at our project RocketChat#232

@engelgabriel
Copy link
Author

On my first look, lots of the changes can be turned into SETTINGS, and another big part, the Access Permissions, is something we would love to add to the main project.

@engelgabriel
Copy link
Author

Hi @bbrockman did you give on this?

@bbrockman
Copy link

Hello @engelgabriel! Not really. We were in charge of doing a 'prototype'. We have completed as far as we will go with the prototype, but it is likely that there will be additional development in the future. I appreciate all the work you guys have put into this and wish you the best of luck! I'm sorry we had such a quick turnaround to complete our prototype and weren't able to integrate together more. Maybe another time.

@engelgabriel
Copy link
Author

Thats ok! I presume you did see what @rwakida merge back into our code? The roles and permissions.

@bbrockman
Copy link

I did. @rwakida is awesome.

@engelgabriel
Copy link
Author

I can't agree more! @rwakida is awesome indeed! Does this change make it easier for you guys to keep in sync?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants