Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetSecurityBanner invalid user error #13

Closed
rwakida opened this issue Jul 24, 2015 · 1 comment
Closed

GetSecurityBanner invalid user error #13

rwakida opened this issue Jul 24, 2015 · 1 comment
Assignees
Milestone

Comments

@rwakida
Copy link

rwakida commented Jul 24, 2015

To replicate:

  1. Create a channel
  2. Select "general" channel
  3. logout.

[method]getSecurityBanner invalid user error should briefly appear in upper right

@bbrockman bbrockman modified the milestone: Product Backlog Jul 28, 2015
@rwakida rwakida added the bug label Jul 29, 2015
@bbrockman bbrockman modified the milestones: Product Backlog, Sprint 2 Aug 3, 2015
@rwakida
Copy link
Author

rwakida commented Aug 8, 2015

After investigation, the getSecurityBanner method was reactively called after the user logged out. Thus the serverside method threw an error because no userId existed. I modified the getSecurityBanner method to not check for userId because it doesn't return/access sensitive information and doesn't require a user.

@rwakida rwakida self-assigned this Aug 9, 2015
@bbrockman bbrockman added Done and removed In Review labels Aug 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants