Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise wavefield sampler depth calculations #42

Open
5 tasks
srmainwaring opened this issue Jun 30, 2022 · 0 comments
Open
5 tasks

Optimise wavefield sampler depth calculations #42

srmainwaring opened this issue Jun 30, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@srmainwaring
Copy link
Owner

srmainwaring commented Jun 30, 2022

The depth calculation using the WavefieldSampler accounts for about 18% of the compute time in the hydrodynamics update. This issue is to track improvements to optimise performance.

  • Axis align the water patch with the coordinates used for the link / collision mesh
  • Create version of water patch and grid that does not require CGAL
    • Assume that the line search is always along one axis (z)
    • Take care with floating point comparisions when determining the cell / triangle each vertex projects into
    • Precalculate normals and plane equations for each triangle
@srmainwaring srmainwaring added the enhancement New feature or request label Jun 30, 2022
@srmainwaring srmainwaring self-assigned this Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant