Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container attachement without subshelling #68

Closed
hellt opened this issue Sep 27, 2020 · 0 comments · Fixed by #209
Closed

container attachement without subshelling #68

hellt opened this issue Sep 27, 2020 · 0 comments · Fixed by #209

Comments

@hellt
Copy link
Member

hellt commented Sep 27, 2020

In this PR weaveworks moved from shell based container attachement to Go/syscall based
this can be used for inspiration; for instance remove ethtool subshelling and/or creating veth pairs

weaveworks/weave#2307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed subshelling for link creation srl-labs/containerlab
1 participant
@hellt