Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shake cache is shared between multiple targets #96

Closed
srid opened this issue Jan 21, 2020 · 2 comments · Fixed by #109
Closed

Shake cache is shared between multiple targets #96

srid opened this issue Jan 21, 2020 · 2 comments · Fixed by #109
Labels
bug Something isn't working shake
Milestone

Comments

@srid
Copy link
Owner

srid commented Jan 21, 2020

Different target directories use the same Shake cache.

@srid srid added the bug Something isn't working label Jan 21, 2020
@srid srid added this to the 0.7 milestone Jan 21, 2020
@srid
Copy link
Owner Author

srid commented Jan 22, 2020

Not really. The cache key already contains the full target path. However if the user deletes a target file, that is not taken into the account - and Shake thinks that file need not be recreated because it is cached (at least, that's my theory).

@srid
Copy link
Owner Author

srid commented Jan 23, 2020

Probably to do with symlinks. To test this theory, resolve the filepath to remove any symlinks before using it in cacheKey and cacheClosure (Rib.Shake.writeFileCached).

EDIT: Just check for missing files, and invalidate their cache. To reproduce, rm -rf ./b and re-run the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working shake
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant