Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impulse: tags with emoji or spaces #505

Closed
gillchristian opened this issue Dec 29, 2020 · 5 comments
Closed

Impulse: tags with emoji or spaces #505

gillchristian opened this issue Dec 29, 2020 · 5 comments

Comments

@gillchristian
Copy link
Contributor

Links to tag search don't work on Impulse when the tag contains emoji or spaces.

Searching directly in Impulse for a tag that includes emoji works. But it doesn't for tags with spaces.

As a side note, links containing emoji, spaces or both do work on Cerveau:

@srid
Copy link
Owner

srid commented Dec 29, 2020

Can emojis be used in zettel IDs and filenames?

(Soon enough, tags can only contain exactly what's allowed in zettel ID)

@srid
Copy link
Owner

srid commented Dec 29, 2020

Spaces ... we should definitely support.

Might have to allow quotting in the search query (as it gets improved), i.e.: tag:"Foo Bar"

@gillchristian
Copy link
Contributor Author

Can emojis be used in zettel IDs and filenames?

At least not in file names. So I guess it makes sense they don't work on tags either.

Spaces ... we should definitely support.

Might have to allow quotting in the search query (as it gets improved), i.e.: tag:"Foo Bar"

Should I close this issue and open one specific for spaces? Or is that already under the radar?

@srid
Copy link
Owner

srid commented Dec 30, 2020

Yes, spaces will have to get supported as part of #379. Some things to consider:

  • Inline tags (#foo) may not support spaces.
  • However, we can "extend" inline tag syntax so that it can support full range of zettel IDs. eg: #[[Foo bar]].
    • Basically the syntax is same as for links, but we tack in a # at the beginning.
    • This means, we would have three types of links: [[ (cf), [[[ (folge), #[[ (reverse-folge).
      • But the second can be treated as an alias for the third; so in effect, there are only two types.
  • In YAML metadata, you can already use spaces by quoting, tags: [ "Foo bar"]

EDIT: More thoughts on this at Matrix

@gillchristian
Copy link
Contributor Author

Yeah, there are several cases to cover to fully support spaces in tags.

Closing this since #379 will cover it.

Will checkout the conversation at Matrix 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants