Applies source{d} branding to CodeMirror UAST Modal #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo Baeta <[email protected]>
carlosms
approved these changes
Aug 16, 2019
dpordomingo
reviewed
Aug 16, 2019
Signed-off-by: Ricardo Baeta <[email protected]>
|
@dpordomingo Solved :) |
Signed-off-by: Ricardo Baeta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full rationale of these changes can be seen on the source{d} branding design doc.
Do not merge yet, if reviewed & approved, it still needs some product validation.
Before:
After:
