Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative URLs in welcome dashboard markdown #211

Closed
marnovo opened this issue Jul 16, 2019 · 0 comments · Fixed by #212
Closed

Relative URLs in welcome dashboard markdown #211

marnovo opened this issue Jul 16, 2019 · 0 comments · Fixed by #212
Assignees

Comments

@marnovo
Copy link
Member

marnovo commented Jul 16, 2019

Just noticed when running source{d} CE on a GCP cluster that the URLs in the welcome dashboards are not relative, but hard-coded with local server IP. E.g.:

### Before you get started

You can come back to this Welcome dashboard at any point for references and information:
via browser navigation, [URL](http://127.0.0.1:8088/superset/dashboard/welcome-local/) or in the [list of dashboards](http://127.0.0.1:8088/dashboard/list/).

You can refer to the [source{d} CE full documentation](https://docs.sourced.tech/community-edition/) for more in-depth content.
### Visualize your data on dashboards

- **[Explore source code-related use cases & metrics](http://127.0.0.1:8088/superset/dashboard/1/)**

_Note: You may also create your own metrics, charts & dashboards._

_Note: Very large datasets may eventually cause timeouts loading charts. If this happens, refresh a few at a time._

I guess just removing that would make them relative? Worth checking in the code if this affects anything other than the welcome markdown files.

@smacker smacker self-assigned this Jul 17, 2019
@smacker smacker transferred this issue from src-d/sourced-ce Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants