Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual testing for typography branch #134

Closed
smacker opened this issue Jun 18, 2019 · 5 comments · Fixed by #139
Closed

Manual testing for typography branch #134

smacker opened this issue Jun 18, 2019 · 5 comments · Fixed by #139
Assignees
@smacker @carlosms @ricardobaeta @dpordomingo
Labels
enhancement New feature or request product-design Visual, branding, typography

Comments

@smacker
Copy link
Contributor

smacker commented Jun 18, 2019 •
edited by dpordomingo
Loading

  1. Checkout to sourced-ui-branding branch
  2. Rebase it on master if needed
  3. Go through issues related to branding/typography, make sure they are fixed
  4. Go through pages see that nothing new is broken
  5. Create a PR from the branch (or commit if the branch contains non-typography commits already)
@dpordomingo
Copy link
Contributor

About

3. Go through open issues in this repo related to redesign, make sure they are fixed

Is there any way to know which issues should be validated?
A list of issues would be welcomed for newcomers 🤓

/cc @ricardobaeta @smacker

@dpordomingo
Copy link
Contributor

About

1. Checkout to typography branch

which branch/commits contains the changes to be validated?
https://github.com/src-d/sourced-ui/branches/all

@dpordomingo
Copy link
Contributor

About

3. Go through open issues in this repo related to redesign, make sure they are fixed

@ricardobaeta sent me by slack:

Let me know if there's any other that I should consider

@smacker
Copy link
Contributor Author

smacker commented Jun 19, 2019

Screenshot 2019-06-19 at 18 04 18

Screenshot 2019-06-19 at 18 04 29

@dpordomingo
Copy link
Contributor

commit containing typograpy: abb3431

@dpordomingo dpordomingo self-assigned this Jun 20, 2019
@dpordomingo dpordomingo added bug Something isn't working enhancement New feature or request product-design Visual, branding, typography and removed bug Something isn't working labels Jun 20, 2019
@dpordomingo dpordomingo mentioned this issue Jun 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smacker smacker

@carlosms carlosms

@ricardobaeta ricardobaeta

@dpordomingo dpordomingo

Labels
enhancement New feature or request product-design Visual, branding, typography
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Branding typography dpordomingo/sourced-ui
4 participants
@smacker @carlosms @ricardobaeta @dpordomingo